Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4903)

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.cc

Issue 1404793007: Restart the browsing data counters when the CBD dialog is opened. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a comment about parameters. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/clear_browser_data_handler.cc
diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
index 5648c684337f8200077e72f8ba40e0732f85b416..b37b79a5073c89e94a5744f6ea8ed3cf6764631d 100644
--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.cc
@@ -97,10 +97,6 @@ void ClearBrowserDataHandler::InitializePage() {
web_ui()->CallJavascriptFunction("ClearBrowserDataOverlay.setClearing",
base::FundamentalValue(removal_in_progress));
- for (BrowsingDataCounter* counter : counters_) {
- DCHECK(AreCountersEnabled());
- counter->Restart();
- }
web_ui()->CallJavascriptFunction(
"ClearBrowserDataOverlay.markInitializationComplete");
}
@@ -128,6 +124,13 @@ void ClearBrowserDataHandler::UpdateInfoBannerVisibility() {
base::StringValue(text));
}
+void ClearBrowserDataHandler::OnPageOpened(const base::ListValue* value) {
+ for (BrowsingDataCounter* counter : counters_) {
+ DCHECK(AreCountersEnabled());
+ counter->Restart();
+ }
+}
+
void ClearBrowserDataHandler::GetLocalizedValues(
base::DictionaryValue* localized_strings) {
DCHECK(localized_strings);
@@ -193,6 +196,9 @@ void ClearBrowserDataHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback("performClearBrowserData",
base::Bind(&ClearBrowserDataHandler::HandleClearBrowserData,
base::Unretained(this)));
+ web_ui()->RegisterMessageCallback("openedClearBrowserData",
+ base::Bind(&ClearBrowserDataHandler::OnPageOpened,
+ base::Unretained(this)));
}
void ClearBrowserDataHandler::HandleClearBrowserData(
« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698