Issue 1404473003: Add passthrough GP for cases where no color or coverage should be emitted by GP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1404473003: Add passthrough GP for cases where no color or coverage should be emitted by GP (Closed)

Created:
5 years, 2 months ago by bsalomon

Modified:
5 years, 2 months ago

Reviewers:
egdaniel, *joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add passthrough GP for cases where no color or coverage should be emitted by GP

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -6 lines)			Patch
M	gyp/gpu.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/GrAtlasTextContext.cpp	View	1 chunk	+10 lines, -6 lines	0 comments	Download
M	src/gpu/GrGeometryProcessor.h	View	1 chunk	+7 lines, -0 lines	1 comment	Download
A	src/gpu/GrGeometryProcessor.cpp	View	1 chunk	+48 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1397123002 Patch 160001

Messages

Total messages: 5 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

egdaniel

5 years, 2 months ago (2015-10-14 21:22:13 UTC) #5

lgtm with minor nit, but requiring josh to confirm the GP is set up correctly

https://codereview.chromium.org/1404473003/diff/1/src/gpu/GrGeometryProcessor.h
File src/gpu/GrGeometryProcessor.h (right):

https://codereview.chromium.org/1404473003/diff/1/src/gpu/GrGeometryProcessor...
src/gpu/GrGeometryProcessor.h:24: *  attribute (vec1, offset=0) and passes it
through. It does no color or coverage calculation
extra space at start of comment?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages