Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1397123002: Move functions from SkGr to SkGrPriv.h (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : restore sample app #

Patch Set 3 : fix gyp #

Patch Set 4 : filter quality back to skgr.h #

Patch Set 5 : fix up includes #

Patch Set 6 : fix up non-gpu build #

Patch Set 7 : more no-gpu fix up #

Patch Set 8 : try again to fix no gpu #

Patch Set 9 : 9th time's a charm? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -78 lines) Patch
M example/HelloWorld.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/utils.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/SkGr.h View 1 2 3 4 3 chunks +18 lines, -69 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkLightingShader.cpp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 2 3 4 3 chunks +44 lines, -0 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImageShader.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkImageGeneratorUtils.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkWindow.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/GrGetCoeffBlendKnownComponentsTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/VisualBench/VisualBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1400933002 Patch 1
Issue 1404433002 Patch 1
Issue 1404433002 Patch 20001
Issue 1404433002 Patch 40001
Issue 1404433002 Patch 60001
Issue 1404473003 Patch 1

Messages

Total messages: 33 (16 generated)
bsalomon
5 years, 2 months ago (2015-10-09 17:42:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397123002/20001
5 years, 2 months ago (2015-10-09 17:42:48 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-09 17:42:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3542) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 2 months ago (2015-10-09 17:43:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397123002/40001
5 years, 2 months ago (2015-10-09 18:04:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3545)
5 years, 2 months ago (2015-10-09 18:05:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397123002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397123002/80001
5 years, 2 months ago (2015-10-09 18:15:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3546)
5 years, 2 months ago (2015-10-09 18:16:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397123002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397123002/100001
5 years, 2 months ago (2015-10-09 18:24:50 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3547)
5 years, 2 months ago (2015-10-09 18:25:32 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397123002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397123002/120001
5 years, 2 months ago (2015-10-09 18:29:33 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3548) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 2 months ago (2015-10-09 18:30:43 UTC) #23
reed1
Weeeeeeeeeeeeeeeeee lgtm
5 years, 2 months ago (2015-10-09 19:12:07 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397123002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397123002/140001
5 years, 2 months ago (2015-10-09 20:19:13 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3554)
5 years, 2 months ago (2015-10-09 20:20:10 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1397123002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1397123002/160001
5 years, 2 months ago (2015-10-09 20:29:57 UTC) #32
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 20:36:47 UTC) #33
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/f276ac5c16d39a2b877300d760041f0291bb5ec9

Powered by Google App Engine
This is Rietveld 408576698