Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1404433002: Remove image usage type enum. Use GrTextureParams instead. (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove image usage type enum. Use GrTextureParams instead. BUG=skia: Committed: https://skia.googlesource.com/skia/+/afa95e270c64c9777647b6c58b796750ced57c39

Patch Set 1 #

Patch Set 2 : add file #

Patch Set 3 : cleanup #

Patch Set 4 : fix no gpu build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -279 lines) Patch
M gm/image_pict.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImageGenerator.h View 3 chunks +6 lines, -5 lines 0 comments Download
M include/core/SkImageInfo.h View 1 chunk +1 line, -17 lines 0 comments Download
M include/gpu/GrTextureAccess.h View 1 chunk +1 line, -92 lines 0 comments Download
A include/gpu/GrTextureParams.h View 1 1 chunk +110 lines, -0 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageCacherator.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 1 2 3 10 chunks +15 lines, -15 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkImageGenerator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkLightingShader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPictureImageGenerator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextureMaker.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 8 chunks +10 lines, -9 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 2 6 chunks +26 lines, -81 lines 0 comments Download
M src/gpu/SkGrPriv.h View 1 2 3 6 chunks +6 lines, -8 lines 0 comments Download
M src/image/SkImageShader.cpp View 1 chunk +1 line, -11 lines 0 comments Download
M src/image/SkImage_Base.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/image/SkImage_Generator.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/utils/SkImageGeneratorUtils.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1397123002 Patch 160001

Messages

Total messages: 14 (6 generated)
bsalomon
Lots of files, but changes are simple.
5 years, 2 months ago (2015-10-12 15:37:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404433002/40001
5 years, 2 months ago (2015-10-12 15:37:48 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3563) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 2 months ago (2015-10-12 15:38:43 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404433002/60001
5 years, 2 months ago (2015-10-12 16:04:27 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-12 16:11:22 UTC) #10
reed1
lgtm
5 years, 2 months ago (2015-10-12 16:59:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1404433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1404433002/60001
5 years, 2 months ago (2015-10-12 17:38:54 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 17:39:49 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/afa95e270c64c9777647b6c58b796750ced57c39

Powered by Google App Engine
This is Rietveld 408576698