-Fix display of megamorphic miss function.

-Fix display of megamorphic miss function.
-Fix inbound reference of megamorphic miss function.
-Speculative fix for eval Script.
-Rationalize isolate list as isolate list.
-Fix attempted eval in precompiled isolate.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/8df96f0f48b42dc183205f4121f2b58c911f2857

[rmacnak, 2015-10-13 04:09:44]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-10-13 16:23:15]

LGTM with some nits

https://codereview.chromium.org/1403883002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/app/application.dart (right):

https://codereview.chromium.org/1403883002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/app/application.dart:230: if (e.code ==
ServerRpcException.kCannotAddBreakpoint) return;
Maybe log at a fine grained level that we dropped this?

https://codereview.chromium.org/1403883002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/elements/isolate_ref.html (right):

https://codereview.chromium.org/1403883002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/elements/isolate_ref.html:5: <a on-click="{{ goto
}}" _href="{{ url }}">Isolate {{ ref.number }} ({{ ref.name }})</a>
I wonder if we want the number after the name?

https://codereview.chromium.org/1403883002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1403883002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:1767: js->PrintError(kFeatureDisabled, "Cannot evaluate
after precompilation");
How about:

Cannot evaluate when running a precompiled Dart application.

[rmacnak, 2015-10-13 17:26:33]

https://codereview.chromium.org/1403883002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/app/application.dart (right):

https://codereview.chromium.org/1403883002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/app/application.dart:230: if (e.code ==
ServerRpcException.kCannotAddBreakpoint) return;
On 2015/10/13 16:23:14, Cutch wrote:
> Maybe log at a fine grained level that we dropped this?

Done.

https://codereview.chromium.org/1403883002/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/1403883002/diff/1/runtime/vm/service.cc#newco...
runtime/vm/service.cc:1767: js->PrintError(kFeatureDisabled, "Cannot evaluate
after precompilation");
On 2015/10/13 16:23:15, Cutch wrote:
> How about:
> 
> Cannot evaluate when running a precompiled Dart application.

Done.

[rmacnak, 2015-10-13 17:26:48]

Committed patchset #1 (id:1) manually as
8df96f0f48b42dc183205f4121f2b58c911f2857 (presubmit successful).