Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: runtime/vm/service.cc

Issue 1403883002: -Fix display of megamorphic miss function. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 4662ff9fdd0a1a90e602fc52a4ab9578b5f16ec1..a548faa1638a56c889870df06261f49c25e9d294 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -1763,6 +1763,10 @@ static const MethodParameter* evaluate_params[] = {
static bool Evaluate(Isolate* isolate, JSONStream* js) {
+ if (!isolate->compilation_allowed()) {
+ js->PrintError(kFeatureDisabled, "Cannot evaluate after precompilation");
Cutch 2015/10/13 16:23:15 How about: Cannot evaluate when running a precomp
rmacnak 2015/10/13 17:26:33 Done.
+ return true;
+ }
const char* target_id = js->LookupParam("targetId");
if (target_id == NULL) {
PrintMissingParamError(js, "targetId");
@@ -1832,6 +1836,10 @@ static const MethodParameter* evaluate_in_frame_params[] = {
static bool EvaluateInFrame(Isolate* isolate, JSONStream* js) {
+ if (!isolate->compilation_allowed()) {
+ js->PrintError(kFeatureDisabled, "Cannot evaluate after precompilation");
+ return true;
+ }
DebuggerStackTrace* stack = isolate->debugger()->StackTrace();
intptr_t framePos = UIntParameter::Parse(js->LookupParam("frameIndex"));
if (framePos > stack->Length()) {
« runtime/observatory/lib/src/elements/isolate_ref.html ('K') | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698