Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 part of app; | 5 part of app; |
| 6 | 6 |
| 7 class Notification { | 7 class Notification { |
| 8 Notification.fromEvent(this.event); | 8 Notification.fromEvent(this.event); |
| 9 Notification.fromException(this.exception, this.stacktrace); | 9 Notification.fromException(this.exception, this.stacktrace); |
| 10 | 10 |
| (...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 217 event.kind == ServiceEvent.kConnectionClosed); | 217 event.kind == ServiceEvent.kConnectionClosed); |
| 218 }); | 218 }); |
| 219 } | 219 } |
| 220 | 220 |
| 221 loadCrashDump(Map crashDump) { | 221 loadCrashDump(Map crashDump) { |
| 222 this.vm = new FakeVM(crashDump['result']); | 222 this.vm = new FakeVM(crashDump['result']); |
| 223 app.locationManager.go('#/vm'); | 223 app.locationManager.go('#/vm'); |
| 224 } | 224 } |
| 225 | 225 |
| 226 void handleException(e, st) { | 226 void handleException(e, st) { |
| 227 if (e is ServerRpcException) { | |
| 228 if (e.code == ServerRpcException.kFeatureDisabled) return; | |
| 229 if (e.code == ServerRpcException.kVMMustBePaused) return; | |
| 230 if (e.code == ServerRpcException.kCannotAddBreakpoint) return; | |
|
Cutch
2015/10/13 16:23:14
Maybe log at a fine grained level that we dropped
rmacnak
2015/10/13 17:26:33
Done.
| |
| 231 } | |
| 232 | |
| 227 // TODO(turnidge): Report this failure via analytics. | 233 // TODO(turnidge): Report this failure via analytics. |
| 228 Logger.root.warning('Caught exception: ${e}\n${st}'); | 234 Logger.root.warning('Caught exception: ${e}\n${st}'); |
| 229 notifications.add(new Notification.fromException(e, st)); | 235 notifications.add(new Notification.fromException(e, st)); |
| 230 } | 236 } |
| 231 | 237 |
| 232 // This map keeps track of which curly-blocks have been expanded by the user. | 238 // This map keeps track of which curly-blocks have been expanded by the user. |
| 233 Map<String,bool> expansions = {}; | 239 Map<String,bool> expansions = {}; |
| 234 } | 240 } |
| OLD | NEW |