Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: runtime/observatory/lib/src/elements/isolate_summary.html

Issue 1403883002: -Fix display of megamorphic miss function. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/isolate_summary.html
diff --git a/runtime/observatory/lib/src/elements/isolate_summary.html b/runtime/observatory/lib/src/elements/isolate_summary.html
index 8365cb2461b74624c500c5ea35d1f82223890d92..c146bfac194d2c7617960db3d1b624f6d8d73753 100644
--- a/runtime/observatory/lib/src/elements/isolate_summary.html
+++ b/runtime/observatory/lib/src/elements/isolate_summary.html
@@ -9,36 +9,18 @@
<template>
<link rel="stylesheet" href="css/shared.css">
<div class="flex-row">
- <div class="flex-item-10-percent">
- <img src="img/isolate_icon.png">
- </div>
- <div class="flex-item-10-percent">
- {{ isolate.number }}
- </div>
- <div class="flex-item-20-percent">
+ <div>
<isolate-ref ref="{{ isolate }}"></isolate-ref>
</div>
- <div class="flex-item-10-percent">
+ <div style="flex:1"></div>
+ <div>
<isolate-run-state isolate="{{ isolate }}"></isolate-run-state>
- </div>
- <div class="flex-item-40-percent">
<isolate-location isolate="{{ isolate }}"></isolate-location>
[<a on-click="{{ goto }}" _href="{{ gotoLink('/debugger', isolate) }}">debug</a>]
</div>
- <div class="flex-item-10-percent">
- </div>
</div>
-
- <div class="flex-row">
- <div class="flex-item-20-percent"></div>
- <div class="flex-item-60-percent">
- <hr>
- </div>
- <div class="flex-item-20-percent"></div>
- </div>
-
+ <br>
<isolate-shared-summary isolate="{{ isolate }}"></isolate-shared-summary>
-
</template>
</polymer-element>
@@ -106,7 +88,7 @@
.errorBox {
background-color: #f5f5f5;
border: 1px solid #ccc;
- padding: 10px;
+ padding: 2em;
font-family: consolas, courier, monospace;
font-size: 1em;
line-height: 1.2em;
@@ -121,10 +103,10 @@
</div>
</template>
<div class="flex-row">
- <div class="flex-item-50-percent">
+ <div style="flex:2">
<isolate-counter-chart counters="{{ isolate.counters }}"></isolate-counter-chart>
</div>
- <div class="flex-item-40-percent">
+ <div style="flex:1">
<div class="memberList">
<div class="memberItem">
<div class="memberName">new heap</div>
@@ -204,8 +186,6 @@
</template>
-->
</div>
- <div class="flex-item-10-percent">
- </div>
</div>
</template>
</polymer-element>
@@ -216,20 +196,24 @@
<style>
.chart-wrapper {
}
-
.chart-host-wrapper {
- height: 200px;
+ display: flex;
+ flex-direction: row;
+ max-height: 250px;
+}
+.chart-host {
+ flex: 1;
}
.chart-legend-host {
- max-height: 200px;
+ flex: 1;
overflow-x: auto;
overflow-y: auto;
}
</style>
<div class="chart-wrapper" id="isolate-counter-chart">
<div class="chart-host-wrapper">
- <div class="chart-host" id="isolate-counter-chart-host"></div>
- <div class="chart-legend-host" id="isolate-counter-chart-legend-host"></div>
+ <div class="chart-host" id="isolate-counter-chart-host"></div>
+ <div class="chart-legend-host" id="isolate-counter-chart-legend-host"></div>
</div>
</div>
</template>

Powered by Google App Engine
This is Rietveld 408576698