DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2)

DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2)

BUG=529471
Committed: https://crrev.com/5676b51eb654be4f8138e08f9755cf68c2bac820
Cr-Commit-Position: refs/heads/master@{#356482}

[pfeldman, 2015-10-27 21:21:48]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-10-27 21:43:49]

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
(right):

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js:104:
debugger;
straw debugger

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:113:
onTextEditorContentLoaded: function()
@override

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:121:
onTextChanged: function(oldRange, newRange)
mind adding JSDoc?

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:124:
this._clearMessages();
Do we abandon old messages? If so, who will clear them in UISourceCode? If not,
where do we show them again?

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:609:
this.dispatchEventToListeners(WebInspector.UISourceCode.Events.MessageRemoved,
message);
For consistency, |message| should be removed from |_messages| before dispatching
this event. Otherwise, it will be observable through messages().

[pfeldman, 2015-10-27 22:35:17]

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js
(right):

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js:104:
debugger;
On 2015/10/27 21:43:49, dgozman wrote:
> straw debugger

Done.

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:113:
onTextEditorContentLoaded: function()
On 2015/10/27 21:43:49, dgozman wrote:
> @override

Done.

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:121:
onTextChanged: function(oldRange, newRange)
On 2015/10/27 21:43:49, dgozman wrote:
> mind adding JSDoc?

Done.

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:124:
this._clearMessages();
On 2015/10/27 21:43:49, dgozman wrote:
> Do we abandon old messages? If so, who will clear them in UISourceCode? If
not,
> where do we show them again?

Good call. Let me erase all messages from uiSourceCode upon editing.

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1403373013/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:609:
this.dispatchEventToListeners(WebInspector.UISourceCode.Events.MessageRemoved,
message);
On 2015/10/27 21:43:49, dgozman wrote:
> For consistency, |message| should be removed from |_messages| before
dispatching
> this event. Otherwise, it will be observable through messages().

Done.

[dgozman, 2015-10-27 22:40:15]

lgtm

[pfeldman, 2015-10-27 23:55:40]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-10-27 23:57:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1403373013/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1403373013/20001

[pfeldman, 2015-10-28 00:00:27]

Description was changed from

==========
DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2)

BUG=547658
==========

to

==========
DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2)

BUG=529471
==========

[commit-bot: I haz the power, 2015-10-28 01:50:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-28 01:51:41]

Patchset 2 (id:??) landed as
https://crrev.com/5676b51eb654be4f8138e08f9755cf68c2bac820
Cr-Commit-Position: refs/heads/master@{#356482}