third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js - Issue 1403373013: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

Issue 1403373013: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/ResourceSourceFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

index ba33ebf7cc616370fb641e96334bc92799d46493..1cd2483954bc953dd7a85888e663122363f59855 100644

--- a/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js

@@ -223,6 +223,10 @@ WebInspector.SourceFrame.prototype = {

this._innerScrollToLineIfNeeded();

+ /**

+ * @param {!WebInspector.TextRange} oldRange

+ * @param {!WebInspector.TextRange} newRange

+ */

onTextChanged: function(oldRange, newRange)

{

if (this._searchResultsChangedCallback)

@@ -605,6 +609,8 @@ WebInspector.TextEditorDelegateForSourceFrame = function(sourceFrame)

WebInspector.TextEditorDelegateForSourceFrame.prototype = {

/**

* @override

+ * @param {!WebInspector.TextRange} oldRange

+ * @param {!WebInspector.TextRange} newRange

onTextChanged: function(oldRange, newRange)

{