Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html

Issue 1403373013: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html
index dbc7a08be133adce5617715b8532bbd2a3ed10e5..311d2b0e4c123f8b76f1e43bb45e6b2615490f34 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html
@@ -4,9 +4,7 @@
<script src="../../../http/tests/inspector/debugger-test.js"></script>
<script src="../../../http/tests/inspector/network-test.js"></script>
<script src="../../../http/tests/inspector/resources-test.js"></script>
-
<script>
-
function addErrorToConsole()
{
console.error("test error message");
@@ -48,8 +46,8 @@ function test()
{
InspectorTest.addResult("Script source was shown.");
shownSourceFrame = sourceFrame;
- InspectorTest.addSniffer(WebInspector.UISourceCodeFrame.prototype, "addMessageToSource", didAddMessage);
- InspectorTest.addSniffer(WebInspector.UISourceCodeFrame.prototype, "clearMessages", clearMessages);
+ InspectorTest.addSniffer(WebInspector.UISourceCodeFrame.prototype, "_addMessageToSource", didAddMessage);
+ InspectorTest.addSniffer(WebInspector.UISourceCodeFrame.prototype, "_removeMessageFromSource", didRemoveMessage);
InspectorTest.evaluateInPage("addErrorToConsole()");
}
@@ -58,14 +56,14 @@ function test()
if (this !== shownSourceFrame)
return;
InspectorTest.addResult("Message added to source frame: " + message.text());
- InspectorTest.consoleModel.requestClearMessages();
+ setImmediate(function() { InspectorTest.consoleModel.requestClearMessages(); });
}
- function clearMessages()
+ function didRemoveMessage(message)
{
if (this !== shownSourceFrame)
return;
- InspectorTest.addResult("Messages cleared in source frame.");
+ InspectorTest.addResult("Message removed from source frame: " + message.text());
next();
}
},
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698