third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js - Issue 1403373013: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js

Issue 1403373013: DevTools: move ui messages from SourceFrame to UISourceCodeFrame (step2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js

index 65efaa8b488f936ceabb6b3eaee06d7f9fec831f..a96afc8ce18514753909f43248236bf807114798 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js

@@ -73,8 +73,7 @@ WebInspector.JavaScriptCompiler.prototype = {

}

if (!exceptionDetails)

return;

- var message = new WebInspector.UISourceCode.Message(WebInspector.UISourceCode.Message.Level.Error, exceptionDetails.text, exceptionDetails.line - 1, exceptionDetails.column + 1);

- this._sourceFrame.addMessageToSource(message);

+ this._sourceFrame.uiSourceCode().addMessage(WebInspector.UISourceCode.Message.Level.Error, exceptionDetails.text, exceptionDetails.line - 1, exceptionDetails.column + 1);

this._compilationFinishedForTest();

}