Issue 1403353002: [Interpreter] Move globals to use idx16 operand for slot id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1403353002: [Interpreter] Move globals to use idx16 operand for slot id. (Closed)

Created:
5 years, 2 months ago by rmcilroy

Modified:
5 years, 2 months ago

Reviewers:

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[Interpreter] Move globals to use idx16 operand for slot id. Almost all scripts will end up with more than 256 globals, so it's not really worth having 8-bit variants of the bytecode. BUG=v8:4280 LOG=N

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -35 lines)			Patch
M	src/interpreter/bytecode-array-builder.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/interpreter/bytecodes.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/interpreter/interpreter.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/interpreter/test-bytecode-generator.cc	View	1	9 chunks	+26 lines, -26 lines	0 comments	Download

Depends on Patchset:

Issue 1406183002 Patch 1

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmcilroy

5 years, 2 months ago (2015-10-22 10:29:47 UTC) #1

Description was changed from

==========
[Interpreter] Move globals to use idx16 operand for slot id.

Almost all scripts will end up with more than 256 globals, so it's not really
worth having 8-bit variants of the bytecode.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Move globals to use idx16 operand for slot id.

Almost all scripts will end up with more than 256 globals, so it's not really
worth having 8-bit variants of the bytecode.

BUG=v8:4280
LOG=N
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages