Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1406183002: [Interpreter] Add support for strict mode global stores. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for strict mode global stores. Adds the bytecode StaGlobalStrict and replaces StaGlobal with StaGlobalSloppy. BUG=v8:4280 LOG=N TBR=bmeurer@chromium.org Committed: https://crrev.com/4414a14d717ff0a462f1605c82b3f8d0b422fb85 Cr-Commit-Position: refs/heads/master@{#31339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -18 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 2 chunks +19 lines, -4 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +17 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 3 chunks +19 lines, -7 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (5 generated)
rmcilroy
PTAL, thanks.
5 years, 2 months ago (2015-10-16 11:26:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183002/1
5 years, 2 months ago (2015-10-16 11:26:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 12:57:23 UTC) #6
oth
lgtm. Thanks!
5 years, 2 months ago (2015-10-16 13:17:47 UTC) #7
rmcilroy
TBRing Benedikt for minor compiler/bytecode-graph-builder.cc change due to new bytecode.
5 years, 2 months ago (2015-10-16 13:52:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406183002/1
5 years, 2 months ago (2015-10-16 13:52:22 UTC) #11
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-10-16 13:53:35 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 13:57:52 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 13:58:24 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4414a14d717ff0a462f1605c82b3f8d0b422fb85
Cr-Commit-Position: refs/heads/master@{#31339}

Powered by Google App Engine
This is Rietveld 408576698