Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1403353002: [Interpreter] Move globals to use idx16 operand for slot id. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/interpreter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index f9756421f6bfe400a43882a7ddb3d3c8b50e75f8..588ee346c34e0857c7f5554ef3ae391becdc2f8e 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -1043,20 +1043,20 @@ TEST(LoadGlobal) {
"var a = 1;\nfunction f() { return a; }\nf()",
0,
1,
- 3,
+ 4,
{
- B(LdaGlobal), _, //
- B(Return) //
+ B(LdaGlobal), _, _, //
+ B(Return) //
},
},
{
"function t() { }\nfunction f() { return t; }\nf()",
0,
1,
- 3,
+ 4,
{
- B(LdaGlobal), _, //
- B(Return) //
+ B(LdaGlobal), _, _, //
+ B(Return) //
},
},
};
@@ -1078,22 +1078,22 @@ TEST(StoreGlobal) {
"var a = 1;\nfunction f() { a = 2; }\nf()",
0,
1,
- 6,
+ 7,
{
- B(LdaSmi8), U8(2), //
- B(StaGlobalSloppy), _, //
- B(LdaUndefined), //
- B(Return) //
+ B(LdaSmi8), U8(2), //
+ B(StaGlobalSloppy), _, _, //
+ B(LdaUndefined), //
+ B(Return) //
},
},
{
"var a = \"test\"; function f(b) { a = b; }\nf(\"global\")",
0,
2,
- 6,
+ 7,
{
B(Ldar), R(helper.kLastParamIndex), //
- B(StaGlobalSloppy), _, //
+ B(StaGlobalSloppy), _, _, //
B(LdaUndefined), //
B(Return) //
},
@@ -1102,12 +1102,12 @@ TEST(StoreGlobal) {
"'use strict'; var a = 1;\nfunction f() { a = 2; }\nf()",
0,
1,
- 6,
+ 7,
{
- B(LdaSmi8), U8(2), //
- B(StaGlobalStrict), _, //
- B(LdaUndefined), //
- B(Return) //
+ B(LdaSmi8), U8(2), //
+ B(StaGlobalStrict), _, _, //
+ B(LdaUndefined), //
+ B(Return) //
},
},
};
@@ -1129,11 +1129,11 @@ TEST(CallGlobal) {
"function t() { }\nfunction f() { return t(); }\nf()",
2 * kPointerSize,
1,
- 12,
+ 13,
{
B(LdaUndefined), //
B(Star), R(1), //
- B(LdaGlobal), _, //
+ B(LdaGlobal), _, _, //
B(Star), R(0), //
B(Call), R(0), R(1), U8(0), //
B(Return) //
@@ -1143,11 +1143,11 @@ TEST(CallGlobal) {
"function t(a, b, c) { }\nfunction f() { return t(1, 2, 3); }\nf()",
5 * kPointerSize,
1,
- 24,
+ 25,
{
B(LdaUndefined), //
B(Star), R(1), //
- B(LdaGlobal), _, //
+ B(LdaGlobal), _, _, //
B(Star), R(0), //
B(LdaSmi8), U8(1), //
B(Star), R(2), //
@@ -1556,7 +1556,7 @@ TEST(DeclareGlobals) {
{"var a = 1;\na=2;",
5 * kPointerSize,
1,
- 52,
+ 53,
{
B(Ldar), R(Register::function_closure().index()), //
B(Star), R(2), //
@@ -1578,7 +1578,7 @@ TEST(DeclareGlobals) {
B(CallRuntime), U16(Runtime::kInitializeVarGlobal), R(2), //
U8(3), //
B(LdaSmi8), U8(2), //
- B(StaGlobalSloppy), _, //
+ B(StaGlobalSloppy), _, _, //
B(Star), R(0), //
B(Ldar), R(0), //
B(Return) //
@@ -1587,7 +1587,7 @@ TEST(DeclareGlobals) {
{"function f() {}\nf();",
4 * kPointerSize,
1,
- 43,
+ 44,
{
B(Ldar), R(Register::function_closure().index()), //
B(Star), R(2), //
@@ -1602,7 +1602,7 @@ TEST(DeclareGlobals) {
B(CallRuntime), U16(Runtime::kDeclareGlobals), R(2), U8(2), //
B(LdaUndefined), //
B(Star), R(3), //
- B(LdaGlobal), _, //
+ B(LdaGlobal), _, _, //
B(Star), R(2), //
B(Call), R(2), R(3), U8(0), //
B(Star), R(0), //
« no previous file with comments | « src/interpreter/interpreter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698