[Interpreter] Move globals to use idx16 operand for slot id.

test/cctest/interpreter/test-bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 #include "src/interpreter/bytecode-generator.h"
 #include "src/interpreter/interpreter.h"
@@ skipping 1025 matching lines @@
 
 TEST(LoadGlobal) {
   InitializedHandleScope handle_scope;
   BytecodeGeneratorHelper helper;
 
   ExpectedSnippet<int> snippets[] = {
       {
           "var a = 1;\nfunction f() { return a; }\nf()",
           0,
           1,
-          3,
+          4,
           {
-              B(LdaGlobal), _,  //
-              B(Return)         //
+              B(LdaGlobal), _, _,  //
+              B(Return)            //
           },
       },
       {
           "function t() { }\nfunction f() { return t; }\nf()",
           0,
           1,
-          3,
+          4,
           {
-              B(LdaGlobal), _,  //
-              B(Return)         //
+              B(LdaGlobal), _, _,  //
+              B(Return)            //
           },
       },
   };
 
   for (size_t i = 0; i < arraysize(snippets); i++) {
     Handle<BytecodeArray> bytecode_array =
         helper.MakeBytecode(snippets[i].code_snippet, "f");
     CheckBytecodeArrayEqual(snippets[i], bytecode_array, true);
   }
 }
 
 
 TEST(StoreGlobal) {
   InitializedHandleScope handle_scope;
   BytecodeGeneratorHelper helper;
 
   ExpectedSnippet<InstanceType> snippets[] = {
       {
           "var a = 1;\nfunction f() { a = 2; }\nf()",
           0,
           1,
-          6,
+          7,
           {
-              B(LdaSmi8), U8(2),      //
-              B(StaGlobalSloppy), _,  //
-              B(LdaUndefined),        //
-              B(Return)               //
+              B(LdaSmi8), U8(2),         //
+              B(StaGlobalSloppy), _, _,  //
+              B(LdaUndefined),           //
+              B(Return)                  //
           },
       },
       {
           "var a = \"test\"; function f(b) { a = b; }\nf(\"global\")",
           0,
           2,
-          6,
+          7,
           {
               B(Ldar), R(helper.kLastParamIndex),  //
-              B(StaGlobalSloppy), _,               //
+              B(StaGlobalSloppy), _, _,            //
               B(LdaUndefined),                     //
               B(Return)                            //
           },
       },
       {
           "'use strict'; var a = 1;\nfunction f() { a = 2; }\nf()",
           0,
           1,
-          6,
+          7,
           {
-              B(LdaSmi8), U8(2),      //
-              B(StaGlobalStrict), _,  //
-              B(LdaUndefined),        //
-              B(Return)               //
+              B(LdaSmi8), U8(2),         //
+              B(StaGlobalStrict), _, _,  //
+              B(LdaUndefined),           //
+              B(Return)                  //
           },
       },
   };
 
   for (size_t i = 0; i < arraysize(snippets); i++) {
     Handle<BytecodeArray> bytecode_array =
         helper.MakeBytecode(snippets[i].code_snippet, "f");
     CheckBytecodeArrayEqual(snippets[i], bytecode_array, true);
   }
 }
 
 
 TEST(CallGlobal) {
   InitializedHandleScope handle_scope;
   BytecodeGeneratorHelper helper;
 
   ExpectedSnippet<int> snippets[] = {
       {
           "function t() { }\nfunction f() { return t(); }\nf()",
           2 * kPointerSize,
           1,
-          12,
+          13,
           {
               B(LdaUndefined),             //
               B(Star), R(1),               //
-              B(LdaGlobal), _,             //
+              B(LdaGlobal), _, _,          //
               B(Star), R(0),               //
               B(Call), R(0), R(1), U8(0),  //
               B(Return)                    //
           },
       },
       {
           "function t(a, b, c) { }\nfunction f() { return t(1, 2, 3); }\nf()",
           5 * kPointerSize,
           1,
-          24,
+          25,
           {
               B(LdaUndefined),             //
               B(Star), R(1),               //
-              B(LdaGlobal), _,             //
+              B(LdaGlobal), _, _,          //
               B(Star), R(0),               //
               B(LdaSmi8), U8(1),           //
               B(Star), R(2),               //
               B(LdaSmi8), U8(2),           //
               B(Star), R(3),               //
               B(LdaSmi8), U8(3),           //
               B(Star), R(4),               //
               B(Call), R(0), R(1), U8(3),  //
               B(Return)                    //
           },
@@ skipping 388 matching lines @@
            B(LdaZero),                                                    //
            B(Star), R(2),                                                 //
            B(CallRuntime), U16(Runtime::kDeclareGlobals), R(1), U8(2),    //
            B(LdaUndefined),                                               //
            B(Return)                                                      //
        },
        -1},
       {"var a = 1;\na=2;",
        5 * kPointerSize,
        1,
-       52,
+       53,
        {
            B(Ldar), R(Register::function_closure().index()),              //
            B(Star), R(2),                                                 //
            B(LdaConstant), U8(0),                                         //
            B(Star), R(3),                                                 //
            B(CallRuntime), U16(Runtime::kNewScriptContext), R(2), U8(2),  //
            B(PushContext), R(1),                                          //
            B(LdaConstant), U8(1),                                         //
            B(Star), R(2),                                                 //
            B(LdaZero),                                                    //
            B(Star), R(3),                                                 //
            B(CallRuntime), U16(Runtime::kDeclareGlobals), R(2), U8(2),    //
            B(LdaConstant), U8(2),                                         //
            B(Star), R(2),                                                 //
            B(LdaZero),                                                    //
            B(Star), R(3),                                                 //
            B(LdaSmi8), U8(1),                                             //
            B(Star), R(4),                                                 //
            B(CallRuntime), U16(Runtime::kInitializeVarGlobal), R(2),      //
                            U8(3),                                         //
            B(LdaSmi8), U8(2),                                             //
-           B(StaGlobalSloppy), _,                                         //
+           B(StaGlobalSloppy), _, _,                                      //
            B(Star), R(0),                                                 //
            B(Ldar), R(0),                                                 //
            B(Return)                                                      //
        },
        -1},
       {"function f() {}\nf();",
        4 * kPointerSize,
        1,
-       43,
+       44,
        {
            B(Ldar), R(Register::function_closure().index()),              //
            B(Star), R(2),                                                 //
            B(LdaConstant), U8(0),                                         //
            B(Star), R(3),                                                 //
            B(CallRuntime), U16(Runtime::kNewScriptContext), R(2), U8(2),  //
            B(PushContext), R(1),                                          //
            B(LdaConstant), U8(1),                                         //
            B(Star), R(2),                                                 //
            B(LdaZero),                                                    //
            B(Star), R(3),                                                 //
            B(CallRuntime), U16(Runtime::kDeclareGlobals), R(2), U8(2),    //
            B(LdaUndefined),                                               //
            B(Star), R(3),                                                 //
-           B(LdaGlobal), _,                                               //
+           B(LdaGlobal), _, _,                                            //
            B(Star), R(2),                                                 //
            B(Call), R(2), R(3), U8(0),                                    //
            B(Star), R(0),                                                 //
            B(Ldar), R(0),                                                 //
            B(Return)                                                      //
        },
        -1},
   };
 
   for (size_t i = 0; i < arraysize(snippets); i++) {
@@ skipping 1062 matching lines @@
   for (size_t i = 0; i < arraysize(snippets); i++) {
     Handle<BytecodeArray> bytecode_array =
         helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
     CheckBytecodeArrayEqual(snippets[i], bytecode_array);
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8