Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
Reviewers:
blundell
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, vabr+watchlist_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, scheduler-bugs_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in components/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 R=blundell@chromium.org Committed: https://crrev.com/15b41157b2c8f731195a6563cc53cf2758a6d0f7 Cr-Commit-Position: refs/heads/master@{#353726}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -32 lines) Patch
M components/autofill/content/browser/risk/fingerprint_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/history/core/browser/history_querying_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/history/core/browser/history_service_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M components/history/core/browser/top_sites_impl_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M components/history/core/test/history_backend_db_base_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/ax_provider_impl_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/nacl/broker/nacl_broker_listener.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/base/task_queue_manager_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/gaia_cookie_manager_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/storage_monitor/media_storage_util_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/storage_monitor/storage_monitor_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_linux_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/wallpaper/wallpaper_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/wifi_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
ki.stfu
5 years, 2 months ago (2015-10-09 19:12:40 UTC) #1
ki.stfu
ping
5 years, 2 months ago (2015-10-12 13:42:39 UTC) #2
ki.stfu
blundell@: could you help with the review of this please?
5 years, 2 months ago (2015-10-13 08:36:24 UTC) #4
blundell
lgtm
5 years, 2 months ago (2015-10-13 11:29:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1402553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1402553002/1
5 years, 2 months ago (2015-10-13 12:20:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 13:01:01 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 13:01:42 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/15b41157b2c8f731195a6563cc53cf2758a6d0f7
Cr-Commit-Position: refs/heads/master@{#353726}

Powered by Google App Engine
This is Rietveld 408576698