components/history/core/browser/history_querying_unittest.cc - Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_querying_unittest.cc

Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/web_data_service_unittest.cc ('k') | components/history/core/browser/history_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/history_querying_unittest.cc

diff --git a/components/history/core/browser/history_querying_unittest.cc b/components/history/core/browser/history_querying_unittest.cc

index 535688c0fcdb96c424d24b4fe0ee46e64cf2fe6b..98dd62fa67ff4fe2e477e1edf0938747dd17a375 100644

--- a/components/history/core/browser/history_querying_unittest.cc

+++ b/components/history/core/browser/history_querying_unittest.cc

@@ -180,7 +180,8 @@ class HistoryQueryTest : public testing::Test {

void TearDown() override {

if (history_) {

- history_->SetOnBackendDestroyTask(base::MessageLoop::QuitClosure());

+ history_->SetOnBackendDestroyTask(

+ base::MessageLoop::QuitWhenIdleClosure());

history_->Cleanup();

history_.reset();

base::MessageLoop::current()->Run(); // Wait for the other thread.

@@ -189,7 +190,8 @@ class HistoryQueryTest : public testing::Test {

void QueryHistoryComplete(QueryResults* results) {

results->Swap(&last_query_results_);

- base::MessageLoop::current()->Quit(); // Will return out to QueryHistory.

+ base::MessageLoop::current()

+ ->QuitWhenIdle(); // Will return out to QueryHistory.

}

base::ScopedTempDir temp_dir_;