components/autofill/core/browser/webdata/web_data_service_unittest.cc - Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/web_data_service_unittest.cc

Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/personal_data_manager_unittest.cc ('k') | components/history/core/browser/history_querying_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/web_data_service_unittest.cc

diff --git a/components/autofill/core/browser/webdata/web_data_service_unittest.cc b/components/autofill/core/browser/webdata/web_data_service_unittest.cc

index d3cc875603008cdfd735735e549bfbcd60beb211..5f3d80b4c82fa96f229bb1e3479799654368111c 100644

--- a/components/autofill/core/browser/webdata/web_data_service_unittest.cc

+++ b/components/autofill/core/browser/webdata/web_data_service_unittest.cc

@@ -59,7 +59,7 @@ class AutofillWebDataServiceConsumer: public WebDataServiceConsumer {

static_cast<const WDResult<T>*>(result);

result_ = wrapped_result->GetValue();

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

WebDataServiceBase::Handle handle() { return handle_; }

@@ -120,7 +120,7 @@ class WebDataServiceTest : public testing::Test {

WaitForDatabaseThread();

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE, base::MessageLoop::QuitClosure());

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

base::MessageLoop::current()->Run();

db_thread_.Stop();

}