components/signin/core/browser/gaia_cookie_manager_service_unittest.cc - Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

Issue 1402553002: Don't use base::MessageLoop::{Quit,QuitClosure} in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/template_url_fetcher_unittest.cc ('k') | components/storage_monitor/media_storage_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

diff --git a/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc b/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

index 4f602470d53149692b00e47e80e53a1ada51ca37..78b5c289d8102b27bae30cc05c315cc206ae88a7 100644

--- a/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

+++ b/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc

@@ -221,7 +221,7 @@ TEST_F(GaiaCookieManagerServiceTest, MergeSessionRetried) {

DCHECK(helper.is_running());

// Transient error incurs a retry after 1 second.

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

- FROM_HERE, base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(1100));

base::MessageLoop::current()->Run();

SimulateMergeSessionSuccess(&helper, "token");

@@ -243,14 +243,14 @@ TEST_F(GaiaCookieManagerServiceTest, MergeSessionRetriedTwice) {

DCHECK(helper.is_running());

// Transient error incurs a retry after 1 second.

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

- FROM_HERE, base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(1100));

base::MessageLoop::current()->Run();

SimulateMergeSessionFailure(&helper, canceled());

DCHECK(helper.is_running());

// Next transient error incurs a retry after 3 seconds.

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

- FROM_HERE, base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(3100));

base::MessageLoop::current()->Run();

SimulateMergeSessionSuccess(&helper, "token");