Issue 14015004: Remove call-indirections from type tests.

Issue 14015004: Remove call-indirections from type tests. (Closed)

Created:
7 years, 8 months ago by sra1

Modified:
7 years, 8 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove call-indirections from type tests. The point of variation between different tests is no longer whether a call is needed, but whether the data is on the objects or on the interceptor. Committed: https://code.google.com/p/dart/source/detail?r=21578

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -93 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		2 chunks	+1 line, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View	1	2 chunks	+6 lines, -21 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	1	5 chunks	+16 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_rti.dart	View		2 chunks	+3 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	2 chunks	+1 line, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+4 lines, -10 lines	0 comments	Download
M	tests/compiler/dart2js_native/core_type_check_native_test.dart	View	1	2 chunks	+39 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/14015004/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart File sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart (right): https://codereview.chromium.org/14015004/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart#newcode415 sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:415: bool requiresNativeIsCheck(Element element) { Can't you remove this ...

7 years, 8 months ago (2013-04-16 07:47:12 UTC) #2

sra1

Committed patchset #2 manually as r21578 (presubmit successful).

7 years, 8 months ago (2013-04-16 21:03:44 UTC) #4

sra1

7 years, 8 months ago (2013-04-16 21:15:10 UTC) #5

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/14015004/diff/1/sdk/lib/_internal/comp...
File sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart
(right):

https://chromiumcodereview.appspot.com/14015004/diff/1/sdk/lib/_internal/comp...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:415:
bool requiresNativeIsCheck(Element element) {
On 2013/04/16 07:47:12, ngeoffray wrote:
> Can't you remove this method, and the one above?

It is still used ... I'll add a TODO.

Expand Messages | Collapse Messages