Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 14015004: Remove call-indirections from type tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
index 97c585ccde362a4701c7c1b34710a1b0d9d3c07b..9f85daac07f8c63158d17f89ef286e2b3ee09dc4 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/builder.dart
@@ -2752,8 +2752,6 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
HIs.VARIABLE_CHECK);
} else if (RuntimeTypes.hasTypeArguments(type)) {
Element element = type.element;
- bool needsNativeCheck =
- backend.emitter.nativeEmitter.requiresNativeIsCheck(element);
Element helper = backend.getCheckSubtype();
HInstruction helperCall = new HStatic(helper);
add(helperCall);
@@ -2766,14 +2764,11 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
// have a subclass.
HInstruction asFieldName =
addConstantString(node, backend.namer.substitutionName(element));
- HInstruction native =
- graph.addConstantBool(needsNativeCheck, constantSystem);
List<HInstruction> inputs = <HInstruction>[helperCall,
expression,
isFieldName,
representations,
- asFieldName,
- native];
+ asFieldName];
HInstruction call = new HInvokeStatic(inputs, HType.BOOLEAN);
add(call);
instruction = new HIs(type, <HInstruction>[expression, call],
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/js_rti.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698