Remove call-indirections from type tests.

sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 class NativeEmitter {
 
   CodeEmitterTask emitter;
   CodeBuffer nativeBuffer;
@@ skipping 395 matching lines @@
 
     if (!element.isClass()) {
       compiler.cancel("Is check does not handle element", element: element);
       return false;
     }
 
     return subtypes[element] != null;
   }
 
   bool requiresNativeIsCheck(Element element) {
+    // TODO(sra): Remove this function.  It determines if a native type may
+    // satisfy a check against [element], in whcih case an interceptor must be
+    // used.  We should also use an interceptor if the check can't be satisfied
+    // by a native class in case we get a natibe instance that tries to spoof
+    // the type info.  i.e the criteria for whether or not to use an interceptor
+    // is whether the receiver can be native, not the type of the test.
     if (!element.isClass()) return false;
     ClassElement cls = element;
     if (cls.isNative()) return true;
     return isSupertypeOfNativeClass(element);
   }
 
   void assembleCode(CodeBuffer targetBuffer) {
     List<jsAst.Property> objectProperties = <jsAst.Property>[];
 
     void addProperty(String name, jsAst.Expression value) {
       objectProperties.add(new jsAst.Property(js.string(name), value));
     }
 
-    // Because of native classes, we have to generate some is checks
-    // by calling a method, instead of accessing a property. So we
-    // attach to the JS Object prototype these methods that return
-    // false, and will be overridden by subclasses when they have to
-    // return true.
-    void emitIsChecks() {
-      for (ClassElement element in
-               Elements.sortedByPosition(emitter.checkedClasses)) {
-        if (!requiresNativeIsCheck(element)) continue;
-        if (element.isObject(compiler)) continue;
-        // Add function for the is-test.
-        String name = backend.namer.operatorIs(element);
-        addProperty(name,
-            js.fun([], js.return_(js('false'))));
-        // Add a function for the (trivial) substitution.
-        addProperty(backend.namer.substitutionName(element),
-                    js.fun([], js.return_(js('null'))));
-      }
-    }
-    emitIsChecks();
-
     if (!nativeClasses.isEmpty) {
       // If the native emitter has been asked to take care of the
       // noSuchMethod handlers, we do that now.
       if (handleNoSuchMethod) {
         emitter.emitNoSuchMethodHandlers(addProperty);
       }
     }
 
     // If we have any properties to add to Object.prototype, we run
     // through them and add them using defineProperty.
@@ skipping 13 matching lines @@
       if (emitter.compiler.enableMinification) targetBuffer.add(';');
       targetBuffer.add(jsAst.prettyPrint(
           new jsAst.ExpressionStatement(init), compiler));
       targetBuffer.add('\n');
     }
 
     targetBuffer.add(nativeBuffer);
     targetBuffer.add('\n');
   }
 }