Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 14015004: Remove call-indirections from type tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index 3fee0c20971de91b1823a6905c0d8df09a21501d..24f4a2a272c169148b8b9b5a01f3528ea89e2778 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -2256,16 +2256,10 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
js.PropertyAccess field =
new js.PropertyAccess.field(pop(), backend.namer.operatorIs(element));
- if (backend.emitter.nativeEmitter.requiresNativeIsCheck(element)) {
- push(new js.Call(field, <js.Expression>[]));
- if (negative) push(new js.Prefix('!', pop()));
- } else {
- // We always negate at least once so that the result is boolified.
- push(new js.Prefix('!', field));
- // If the result is not negated, put another '!' in front.
- if (!negative) push(new js.Prefix('!', pop()));
- }
-
+ // We always negate at least once so that the result is boolified.
+ push(new js.Prefix('!', field));
+ // If the result is not negated, put another '!' in front.
+ if (!negative) push(new js.Prefix('!', pop()));
}
void handleNumberOrStringSupertypeCheck(HInstruction input,

Powered by Google App Engine
This is Rietveld 408576698