Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2

Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2

Remove the GetActiveFaviconValidity() check in
FaviconHandler::OnFaviconDataForInitialURLFromFaviconService().
- Calling NotifyFaviconAvailable() on non-Android is inexpensive.
- GetActiveFaviconValidity() is only true during back and forward navigations.
- Android already ignores GetActiveFaviconValidity()
  Android Java solely uses the notifications fired from NotifyFaviconAvailable()
  to determine a page's favicon. It needs to get notifications to update the
  page's favicon as a result of back and forward notifications

BUG=517089
Committed: https://crrev.com/f1b2f5e47074c52c24411f4b90d32396cca4c73f
Cr-Commit-Position: refs/heads/master@{#354026}

[pkotwicz, 2015-10-11 16:12:46]

pkotwicz@chromium.org changed reviewers:
+ sky@chromium.org

[pkotwicz, 2015-10-11 16:35:45]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-10-11 16:38:24]

Scott, can you please take a look?

[sky, 2015-10-12 16:05:32]

https://codereview.chromium.org/1399913002/diff/20001/components/favicon/cont...
File components/favicon/content/content_favicon_driver.h (right):

https://codereview.chromium.org/1399913002/diff/20001/components/favicon/cont...
components/favicon/content/content_favicon_driver.h:50: void
SetActiveFaviconValidity(bool valid) override;
Can you get rid of the setter too? Otherwise this patch is confusing.

[pkotwicz, 2015-10-13 14:46:37]

https://codereview.chromium.org/1399913002/diff/20001/components/favicon/cont...
File components/favicon/content/content_favicon_driver.h (right):

https://codereview.chromium.org/1399913002/diff/20001/components/favicon/cont...
components/favicon/content/content_favicon_driver.h:50: void
SetActiveFaviconValidity(bool valid) override;
I can't remove the setter yet because it is called from
FaviconDriverImpl::OnFaviconAvailable(). I will remove the setter once I clean
up the mess in FaviconDriverImpl::OnFaviconAvailable().

Should I keep the getter?

[sky, 2015-10-13 16:28:55]

Ok, as long as the setter is going to be nuked I'm ok with this. LGTM

[pkotwicz, 2015-10-13 20:37:36]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-10-13 20:37:36]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1399913002/#ps30001
(title: " ")

[commit-bot: I haz the power, 2015-10-13 20:43:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399913002/30001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399913002/30001

[commit-bot: I haz the power, 2015-10-13 20:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-13 20:57:41]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[pkotwicz, 2015-10-14 14:29:22]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-10-14 14:29:22]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1399913002/#ps50001
(title: " ")

[commit-bot: I haz the power, 2015-10-14 14:30:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1399913002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1399913002/50001

[commit-bot: I haz the power, 2015-10-14 15:17:47]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2015-10-14 15:18:33]

Patchset 3 (id:??) landed as
https://crrev.com/f1b2f5e47074c52c24411f4b90d32396cca4c73f
Cr-Commit-Position: refs/heads/master@{#354026}