Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2

components/favicon/content/content_favicon_driver.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_
 #define COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_
 
 #include "components/favicon/core/favicon_driver_impl.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
@@ skipping 29 matching lines @@
   // Saves the favicon for the last committed navigation entry to the thumbnail
   // database.
   void SaveFavicon();
 
   // FaviconDriver implementation.
   gfx::Image GetFavicon() const override;
   bool FaviconIsValid() const override;
   int StartDownload(const GURL& url, int max_bitmap_size) override;
   bool IsOffTheRecord() override;
   GURL GetActiveURL() override;
-  bool GetActiveFaviconValidity() override;
   void SetActiveFaviconValidity(bool valid) override;

[sky, 2015/10/12 16:05:32]

Can you get rid of the setter too? Otherwise this patch is confusing.

[pkotwicz, 2015/10/13 14:46:37]

I can't remove the setter yet because it is called from
FaviconDriverImpl::OnFaviconAvailable(). I will remove the setter once I clean
up the mess in FaviconDriverImpl::OnFaviconAvailable().

Should I keep the getter?

   GURL GetActiveFaviconURL() override;
   void SetActiveFaviconURL(const GURL& url) override;
   void SetActiveFaviconImage(const gfx::Image& image) override;
 
  protected:
   ContentFaviconDriver(content::WebContents* web_contents,
                        FaviconService* favicon_service,
                        history::HistoryService* history_service,
                        bookmarks::BookmarkModel* bookmark_model);
   ~ContentFaviconDriver() override;
@@ skipping 19 matching lines @@
 
   GURL bypass_cache_page_url_;
   std::vector<content::FaviconURL> favicon_urls_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentFaviconDriver);
 };
 
 }  // namespace favicon
 
 #endif  // COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_