components/favicon/core/favicon_handler_unittest.cc - Issue 1399913002: Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_handler_unittest.cc

Issue 1399913002: Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_remove_validity_check

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon/core/favicon_handler_unittest.cc

diff --git a/components/favicon/core/favicon_handler_unittest.cc b/components/favicon/core/favicon_handler_unittest.cc

index ca89afaaf74ad0616a09a00876133a4a221f58cd..2afd9bf9aebb8414cccb0d7fb42dc9feb8672eb1 100644

--- a/components/favicon/core/favicon_handler_unittest.cc

+++ b/components/favicon/core/favicon_handler_unittest.cc

@@ -229,7 +229,7 @@ class TestFaviconDriver : public FaviconDriver {

GURL GetActiveURL() override { return url_; }

- bool GetActiveFaviconValidity() override { return favicon_validity_; }

+ bool GetActiveFaviconValidity() { return favicon_validity_; }

void SetActiveFaviconValidity(bool favicon_validity) override {

favicon_validity_ = favicon_validity;

« no previous file with comments | « components/favicon/core/favicon_handler.cc ('k') | components/favicon/ios/web_favicon_driver.h » ('j') | no next file with comments »