Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: components/favicon/core/favicon_driver.h

Issue 1399913002: Stop FaviconHandler from querying GetActiveFaviconValidity() part 2/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@favicon_remove_validity_check
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/observer_list.h" 9 #include "base/observer_list.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 // Returns whether the user is operating in an off-the-record context. 54 // Returns whether the user is operating in an off-the-record context.
55 virtual bool IsOffTheRecord() = 0; 55 virtual bool IsOffTheRecord() = 0;
56 56
57 // Returns whether |url| is bookmarked. 57 // Returns whether |url| is bookmarked.
58 virtual bool IsBookmarked(const GURL& url) = 0; 58 virtual bool IsBookmarked(const GURL& url) = 0;
59 59
60 // Returns the URL of the current page, if any. Returns an invalid URL 60 // Returns the URL of the current page, if any. Returns an invalid URL
61 // otherwise. 61 // otherwise.
62 virtual GURL GetActiveURL() = 0; 62 virtual GURL GetActiveURL() = 0;
63 63
64 // Returns whether the page's favicon is valid (returns false if the default
65 // favicon is being used).
66 virtual bool GetActiveFaviconValidity() = 0;
67
68 // Sets whether the page's favicon is valid (if false, the default favicon is 64 // Sets whether the page's favicon is valid (if false, the default favicon is
69 // being used). 65 // being used).
70 virtual void SetActiveFaviconValidity(bool valid) = 0; 66 virtual void SetActiveFaviconValidity(bool valid) = 0;
71 67
72 // Returns the URL of the current page's favicon. 68 // Returns the URL of the current page's favicon.
73 virtual GURL GetActiveFaviconURL() = 0; 69 virtual GURL GetActiveFaviconURL() = 0;
74 70
75 // Sets the URL of the favicon's bitmap. 71 // Sets the URL of the favicon's bitmap.
76 virtual void SetActiveFaviconURL(const GURL& url) = 0; 72 virtual void SetActiveFaviconURL(const GURL& url) = 0;
77 73
(...skipping 28 matching lines...) Expand all
106 102
107 private: 103 private:
108 base::ObserverList<FaviconDriverObserver> observer_list_; 104 base::ObserverList<FaviconDriverObserver> observer_list_;
109 105
110 DISALLOW_COPY_AND_ASSIGN(FaviconDriver); 106 DISALLOW_COPY_AND_ASSIGN(FaviconDriver);
111 }; 107 };
112 108
113 } // namespace favicon 109 } // namespace favicon
114 110
115 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_ 111 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_H_
OLDNEW
« no previous file with comments | « components/favicon/content/content_favicon_driver.cc ('k') | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698