Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1399773002: [Interpreter] Adds logical and, logical or and comma operators to interpreter (Closed)

Created:
5 years, 2 months ago by mythria
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Adds logical and/or and comma operators to interpreter Adds support for following operators -Logical and -Logical or -Comma Adds the above bytecodes, support to BytecodeGenerator and BytecodeArrayBuilder to enable it's use, it's implementation and tests. BUG=v8:4280 LOG=N Committed: https://crrev.com/5a09f1b9a776b680a4dac581f37d4c76ebd19118 Cr-Commit-Position: refs/heads/master@{#31281}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added a new bytecode to jump by casting the value to boolean. This reduces code size for logical op… #

Total comments: 26

Patch Set 3 : Modified tests for logical expressions and comma and fixed nits #

Patch Set 4 : Updated a test to avoid using Handle<Object> in initialization because trybots fail. #

Total comments: 10

Patch Set 5 : Fixed few more nits #

Total comments: 2

Patch Set 6 : Fixed formatting problems with the expected bytecode initialization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -110 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 2 chunks +52 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/interpreter/bytecodes.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 3 4 5 1 chunk +202 lines, -105 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 2 3 4 1 chunk +86 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 2 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
mythria
Hi, I have added support for logical and, logical or and Comma operators to the ...
5 years, 2 months ago (2015-10-09 16:08:36 UTC) #2
rmcilroy
https://codereview.chromium.org/1399773002/diff/1/src/interpreter/bytecode-generator.cc File src/interpreter/bytecode-generator.cc (right): https://codereview.chromium.org/1399773002/diff/1/src/interpreter/bytecode-generator.cc#newcode882 src/interpreter/bytecode-generator.cc:882: builder()->Bind(&else_label); I think we should add a pair of ...
5 years, 2 months ago (2015-10-12 07:24:13 UTC) #3
mythria
Hi, This patch includes the following: 1. Adds a new bytecode to jump by casting ...
5 years, 2 months ago (2015-10-13 15:00:00 UTC) #4
rmcilroy
Looking good! A bunch of comments but most are just nits. https://codereview.chromium.org/1399773002/diff/20001/src/compiler/bytecode-graph-builder.cc File src/compiler/bytecode-graph-builder.cc (right): ...
5 years, 2 months ago (2015-10-13 15:43:24 UTC) #5
mythria
Hi, I modified the tests and included few additional tests for logical expressions and Comma. ...
5 years, 2 months ago (2015-10-14 13:33:42 UTC) #6
Benedikt Meurer
LGTM on compiler from my side.
5 years, 2 months ago (2015-10-14 13:36:47 UTC) #7
rmcilroy
LGTM once final nits are addressed, thanks! https://codereview.chromium.org/1399773002/diff/60001/src/interpreter/interpreter.cc File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/1399773002/diff/60001/src/interpreter/interpreter.cc#newcode754 src/interpreter/interpreter.cc:754: // JumpIfToBooleanTrue ...
5 years, 2 months ago (2015-10-14 14:32:44 UTC) #8
mythria
Thanks for your reviews. Addressed all nits from last review. I will land it once ...
5 years, 2 months ago (2015-10-14 14:59:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399773002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399773002/80001
5 years, 2 months ago (2015-10-14 15:32:31 UTC) #12
rmcilroy
https://codereview.chromium.org/1399773002/diff/80001/test/cctest/interpreter/test-bytecode-generator.cc File test/cctest/interpreter/test-bytecode-generator.cc (right): https://codereview.chromium.org/1399773002/diff/80001/test/cctest/interpreter/test-bytecode-generator.cc#newcode472 test/cctest/interpreter/test-bytecode-generator.cc:472: B(LdaSmi8), Bytecode and operands on one line (I've noticed ...
5 years, 2 months ago (2015-10-14 15:34:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399773002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399773002/100001
5 years, 2 months ago (2015-10-15 09:10:32 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-10-15 09:11:43 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 09:12:08 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5a09f1b9a776b680a4dac581f37d4c76ebd19118
Cr-Commit-Position: refs/heads/master@{#31281}

Powered by Google App Engine
This is Rietveld 408576698