Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: src/compiler/bytecode-graph-builder.cc

Issue 1399773002: [Interpreter] Adds logical and, logical or and comma operators to interpreter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Added a new bytecode to jump by casting the value to boolean. This reduces code size for logical op… Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/bytecode-graph-builder.h" 5 #include "src/compiler/bytecode-graph-builder.h"
6 6
7 #include "src/compiler/linkage.h" 7 #include "src/compiler/linkage.h"
8 #include "src/compiler/operator-properties.h" 8 #include "src/compiler/operator-properties.h"
9 #include "src/interpreter/bytecode-array-iterator.h" 9 #include "src/interpreter/bytecode-array-iterator.h"
10 10
(...skipping 512 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 UNIMPLEMENTED(); 523 UNIMPLEMENTED();
524 } 524 }
525 525
526 526
527 void BytecodeGraphBuilder::VisitJumpIfTrueConstant( 527 void BytecodeGraphBuilder::VisitJumpIfTrueConstant(
528 const interpreter::BytecodeArrayIterator& iterator) { 528 const interpreter::BytecodeArrayIterator& iterator) {
529 UNIMPLEMENTED(); 529 UNIMPLEMENTED();
530 } 530 }
531 531
532 532
533 void BytecodeGraphBuilder::VisitJumpIfToBooleanTrue(
534 const interpreter::BytecodeArrayIterator& iterator) {
535 UNIMPLEMENTED();
536 }
537
538
539 void BytecodeGraphBuilder::VisitJumpIfToBooleanTrueConstant(
540 const interpreter::BytecodeArrayIterator& iterator) {
541 UNIMPLEMENTED();
542 }
543
544
533 void BytecodeGraphBuilder::VisitJumpIfFalse( 545 void BytecodeGraphBuilder::VisitJumpIfFalse(
534 const interpreter::BytecodeArrayIterator& iterator) { 546 const interpreter::BytecodeArrayIterator& iterator) {
535 UNIMPLEMENTED(); 547 UNIMPLEMENTED();
536 } 548 }
537 549
538 550
539 void BytecodeGraphBuilder::VisitJumpIfFalseConstant( 551 void BytecodeGraphBuilder::VisitJumpIfFalseConstant(
540 const interpreter::BytecodeArrayIterator& iterator) { 552 const interpreter::BytecodeArrayIterator& iterator) {
541 UNIMPLEMENTED(); 553 UNIMPLEMENTED();
542 } 554 }
543 555
544 556
557 void BytecodeGraphBuilder::VisitJumpIfToBooleanFalse(
rmcilroy 2015/10/13 15:43:24 nit - group the JumpIfToBoolean operators
mythria 2015/10/14 13:33:42 Done.
558 const interpreter::BytecodeArrayIterator& iterator) {
559 UNIMPLEMENTED();
560 }
561
562
563 void BytecodeGraphBuilder::VisitJumpIfToBooleanFalseConstant(
564 const interpreter::BytecodeArrayIterator& iterator) {
565 UNIMPLEMENTED();
566 }
567
568
545 void BytecodeGraphBuilder::VisitReturn( 569 void BytecodeGraphBuilder::VisitReturn(
546 const interpreter::BytecodeArrayIterator& iterator) { 570 const interpreter::BytecodeArrayIterator& iterator) {
547 Node* control = 571 Node* control =
548 NewNode(common()->Return(), environment()->LookupAccumulator()); 572 NewNode(common()->Return(), environment()->LookupAccumulator());
549 UpdateControlDependencyToLeaveFunction(control); 573 UpdateControlDependencyToLeaveFunction(control);
550 } 574 }
551 575
552 576
553 Node** BytecodeGraphBuilder::EnsureInputBufferSize(int size) { 577 Node** BytecodeGraphBuilder::EnsureInputBufferSize(int size) {
554 if (size > input_buffer_size_) { 578 if (size > input_buffer_size_) {
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 670
647 void BytecodeGraphBuilder::UpdateControlDependencyToLeaveFunction(Node* exit) { 671 void BytecodeGraphBuilder::UpdateControlDependencyToLeaveFunction(Node* exit) {
648 if (environment()->IsMarkedAsUnreachable()) return; 672 if (environment()->IsMarkedAsUnreachable()) return;
649 environment()->MarkAsUnreachable(); 673 environment()->MarkAsUnreachable();
650 exit_controls_.push_back(exit); 674 exit_controls_.push_back(exit);
651 } 675 }
652 676
653 } // namespace compiler 677 } // namespace compiler
654 } // namespace internal 678 } // namespace internal
655 } // namespace v8 679 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/interpreter/bytecode-array-builder.h » ('j') | src/interpreter/bytecode-array-builder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698