[Interpreter] Adds logical and, logical or and comma operators to interpreter

test/cctest/interpreter/test-bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 #include "src/interpreter/bytecode-generator.h"
 #include "src/interpreter/interpreter.h"
@@ skipping 377 matching lines @@
        13,
        {
            B(LdaSmi8), U8(10),  //
            B(Star), R(0),       //
            B(Ldar), R(0),       // Easy to spot r1 not really needed here.
            B(Star), R(1),       // Dead store.
            B(LdaSmi8), U8(3),   //
            B(ShiftRightLogical), R(1),  //
            B(Return)                    //
        },
+       0},
+      {"var x = 0; return (x, 3);",
+       1 * kPointerSize,
+       1,
+       8,
+       {
+           B(LdaZero),         //
+           B(Star), R(0),      //
+           B(Ldar), R(0),      //
+           B(LdaSmi8), U8(3),  //
+           B(Return)           //
+       },
        0}};
 
   for (size_t i = 0; i < arraysize(snippets); i++) {
+    Handle<BytecodeArray> bytecode_array =
+        helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
+    CheckBytecodeArrayEqual(snippets[i], bytecode_array);
+  }
+}
+
+
+TEST(LogicalExpressions) {
+  InitializedHandleScope handle_scope;
+  BytecodeGeneratorHelper helper;
+
+
+  ExpectedSnippet<int> snippets[] = {
+      {"var x = 0; return x || 3;",
+       1 * kPointerSize,
+       1,
+       10,
+       {
+           B(LdaZero),                     //
+           B(Star), R(0),                  //
+           B(Ldar), R(0),                  //
+           B(JumpIfToBooleanTrue), U8(4),  //
+           B(LdaSmi8), U8(3),              //
+           B(Return)                       //
+       },
+       0},
+      {"var x = 0; return x && 3;",
+       1 * kPointerSize,
+       1,
+       10,
+       {
+           B(LdaZero),                      //
+           B(Star), R(0),                   //
+           B(Ldar), R(0),                   //
+           B(JumpIfToBooleanFalse), U8(4),  //
+           B(LdaSmi8), U8(3),               //
+           B(Return)                        //
+       },
+       0},
+      {"var x = 1; var a = 2, b = 3; return x || ("
+#define X "a, b, a, b, "
+       X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X
+#undef X
+       "3);",
+       3 * kPointerSize,
+       1,
+       283,
+       {
+           B(LdaSmi8), U8(1),                      //
+           B(Star), R(0),                          //
+           B(LdaSmi8), U8(2),                      //
+           B(Star), R(1),                          //
+           B(LdaSmi8), U8(3),                      //
+           B(Star), R(2),                          //
+           B(Ldar), R(0),                          //
+           B(JumpIfToBooleanTrueConstant), U8(0),  //
+#define X B(Ldar), R(1), B(Ldar), R(2), B(Ldar), R(1), B(Ldar), R(2),
+           X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X  //
+#undef X                                                                      //
+           B(LdaSmi8),

[rmcilroy, 2015/10/14 15:34:01]

Bytecode and operands on one line (I've noticed git cl format seems to barf at
these lines with the "undef X" above it).

+           U8(3),     //
+           B(Return)  //
+       },
+       1,
+       {268, 0, 0, 0}},
+      {"var x = 0; var a = 2, b = 3; return x && ("
+#define X "a, b, a, b, "
+       X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X
+#undef X
+       "3);",
+       3 * kPointerSize,
+       1,
+       282,
+       {
+           B(LdaZero),                              //
+           B(Star), R(0),                           //
+           B(LdaSmi8), U8(2),                       //
+           B(Star), R(1),                           //
+           B(LdaSmi8), U8(3),                       //
+           B(Star), R(2),                           //
+           B(Ldar), R(0),                           //
+           B(JumpIfToBooleanFalseConstant), U8(0),  //
+#define X B(Ldar), R(1), B(Ldar), R(2), B(Ldar), R(1), B(Ldar), R(2),
+           X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X X  //
+#undef X                                                                      //
+           B(LdaSmi8),

[rmcilroy, 2015/10/14 15:34:01]

ditto

+           U8(3),     //
+           B(Return)  //
+       },
+       1,
+       {268, 0, 0, 0}},
+      {"return 0 && 3;",
+       0 * kPointerSize,
+       1,
+       2,
+       {
+           B(LdaZero),  //
+           B(Return)    //
+       },
+       0},
+      {"return 1 || 3;",
+       0 * kPointerSize,
+       1,
+       3,
+       {
+           B(LdaSmi8), U8(1),  //
+           B(Return)           //
+       },
+       0},
+      {"var x = 1; return x && 3 || 0, 1;",
+       1 * kPointerSize,
+       1,
+       16,
+       {
+           B(LdaSmi8), U8(1),               //
+           B(Star), R(0),                   //
+           B(Ldar), R(0),                   //
+           B(JumpIfToBooleanFalse), U8(4),  //
+           B(LdaSmi8), U8(3),               //
+           B(JumpIfToBooleanTrue), U8(3),   //
+           B(LdaZero),                      //
+           B(LdaSmi8), U8(1),               //
+           B(Return)                        //
+       },
+       0}};
+
+  for (size_t i = 0; i < arraysize(snippets); i++) {
     Handle<BytecodeArray> bytecode_array =
         helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
     CheckBytecodeArrayEqual(snippets[i], bytecode_array);
   }
 }
 
 
 TEST(Parameters) {
   InitializedHandleScope handle_scope;
   BytecodeGeneratorHelper helper;
@@ skipping 1636 matching lines @@
   for (size_t i = 0; i < arraysize(snippets); i++) {
     Handle<BytecodeArray> bytecode_array =
         helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
     CheckBytecodeArrayEqual(snippets[i], bytecode_array);
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8