[Interpreter] Adds logical and, logical or and comma operators to interpreter

test/unittests/interpreter/bytecode-array-builder-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/interpreter/bytecode-array-builder.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 #include "test/unittests/test-utils.h"
 
@@ skipping 88 matching lines @@
       .CompareOperation(Token::Value::IN, reg, Strength::WEAK);
 
   // Emit cast operator invocations.
   builder.LoadNull().CastAccumulatorToBoolean();
 
   // Emit control flow. Return must be the last instruction.
   BytecodeLabel start;
   builder.Bind(&start);
   // Short jumps with Imm8 operands
   builder.Jump(&start).JumpIfTrue(&start).JumpIfFalse(&start);
+  builder.JumpIfToBooleanTrue(&start).JumpIfToBooleanFalse(&start);

[rmcilroy, 2015/10/13 15:43:24]

nit - you can avoid the builder. and just make this a followon - i.e.:

builder.Jump(&start).JumpIfTrue(&start).JumpIfFalse(&start)
    .JumpIfToBooleanTrue(&start).JumpIfToBooleanFalse(&start);

[mythria, 2015/10/14 13:33:42]

Done.

   // Insert dummy ops to force longer jumps
   for (int i = 0; i < 128; i++) {
     builder.LoadTrue();
   }
   // Longer jumps requiring Constant operand
   builder.Jump(&start).JumpIfTrue(&start).JumpIfFalse(&start);
+  builder.JumpIfToBooleanTrue(&start).JumpIfToBooleanFalse(&start);
   builder.Return();
 
   // Generate BytecodeArray.
   Handle<BytecodeArray> the_array = builder.ToBytecodeArray();
   CHECK_EQ(the_array->frame_size(), builder.locals_count() * kPointerSize);
 
   // Build scorecard of bytecodes encountered in the BytecodeArray.
   std::vector<int> scorecard(Bytecodes::ToByte(Bytecode::kLast) + 1);
   Bytecode final_bytecode = Bytecode::kLdaZero;
   int i = 0;
@@ skipping 336 matching lines @@
 
   CHECK_EQ(iterator.current_bytecode(), Bytecode::kReturn);
   iterator.Advance();
   CHECK(iterator.done());
 }
 
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8