Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 139673002: Updating Findbugs from 2.0.1 to 2.0.3 (Closed)

Created:
6 years, 11 months ago by aurimas (slooooooooow)
Modified:
6 years, 11 months ago
Base URL:
https://chromium.googlesource.com/chromium/deps/findbugs.git@master
Visibility:
Public.

Description

Updating Findbugs from 2.0.1 to 2.0.3 BUG=None R=bulach@chromium.org Committed: a15fd41 Committed: 245022

Patch Set 1 #

Patch Set 2 : bulach's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3725 lines, -4152 lines) Patch
A OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M doc/Changes.html View 4 chunks +2698 lines, -3438 lines 0 comments Download
M doc/FAQ.html View 4 chunks +12 lines, -26 lines 0 comments Download
M doc/allBugDescriptions.html View 55 chunks +445 lines, -230 lines 0 comments Download
M doc/bugDescriptions.html View 43 chunks +364 lines, -321 lines 0 comments Download
M doc/downloads.html View 1 chunk +31 lines, -31 lines 0 comments Download
M doc/findbugs2.html View 2 chunks +2 lines, -2 lines 0 comments Download
M doc/index.html View 10 chunks +52 lines, -23 lines 0 comments Download
M doc/ja/manual/building.html View 1 chunk +2 lines, -2 lines 0 comments Download
doc/ja/manual/eclipse.html View 1 chunk +1 line, -1 line 0 comments Download
doc/ja/manual/index.html View 1 chunk +1 line, -1 line 0 comments Download
M doc/ja/manual/installing.html View 1 chunk +4 lines, -4 lines 0 comments Download
doc/ja/manual/introduction.html View 1 chunk +1 line, -1 line 0 comments Download
doc/manual.xml View 10 chunks +43 lines, -17 lines 0 comments Download
doc/manual/acknowledgments.html View 3 chunks +5 lines, -5 lines 0 comments Download
doc/manual/anttask.html View 6 chunks +15 lines, -9 lines 0 comments Download
M doc/manual/building.html View 2 chunks +2 lines, -2 lines 0 comments Download
doc/manual/eclipse.html View 4 chunks +8 lines, -8 lines 0 comments Download
doc/manual/filter.html View 7 chunks +7 lines, -7 lines 0 comments Download
doc/manual/gui.html View 3 chunks +5 lines, -5 lines 0 comments Download
doc/manual/index.html View 1 chunk +1 line, -1 line 0 comments Download
doc/manual/installing.html View 1 chunk +6 lines, -6 lines 0 comments Download
doc/manual/introduction.html View 1 chunk +1 line, -1 line 0 comments Download
doc/manual/running.html View 1 chunk +6 lines, -0 lines 0 comments Download
doc/manual_ja.xml View 6 chunks +10 lines, -10 lines 0 comments Download
M lib/annotations.jar View Binary file 0 comments Download
A lib/commons-lang-2.6.jar View Binary file 0 comments Download
M lib/findbugs.jar View Binary file 0 comments Download
M lib/findbugs-ant.jar View Binary file 0 comments Download
M lib/jFormatString.jar View Binary file 0 comments Download
A lib/jaxen-1.1.6.jar View Binary file 0 comments Download
M lib/jsr305.jar View Binary file 0 comments Download
M lib/yjp-controller-api-redist.jar View Binary file 0 comments Download
M optionalPlugin/bugCollectionCloud.jar View Binary file 0 comments Download
M optionalPlugin/noUpdateChecks.jar View Binary file 0 comments Download
M optionalPlugin/poweruser.jar View Binary file 0 comments Download
M plugin/findbugsCommunalCloud.jar View Binary file 0 comments Download
M plugin/webCloudClient.jar View Binary file 0 comments Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
Hey Marcus, Please take a look at this change. Thanks, Aurimas
6 years, 11 months ago (2014-01-15 16:57:26 UTC) #1
bulach
lgtm % nits, thanks! I think this was done ages ago, so mind adding an ...
6 years, 11 months ago (2014-01-15 17:11:46 UTC) #2
aurimas (slooooooooow)
+ben@chromium.org for owners review
6 years, 11 months ago (2014-01-15 17:45:16 UTC) #3
Ben Goodger (Google)
What is this and what part of the chromium repo does this touch such that ...
6 years, 11 months ago (2014-01-15 19:20:02 UTC) #4
aurimas (slooooooooow)
On 2014/01/15 19:20:02, Ben Goodger (Google) wrote: > What is this and what part of ...
6 years, 11 months ago (2014-01-15 19:21:33 UTC) #5
bulach
...and just to clarify, the repository is already there, but I think we created before ...
6 years, 11 months ago (2014-01-15 19:29:33 UTC) #6
aurimas (slooooooooow)
Committed patchset #2 manually as ra15fd41 (presubmit successful).
6 years, 11 months ago (2014-01-15 23:41:13 UTC) #7
aurimas (slooooooooow)
Committed patchset #2 manually as r245022 (presubmit successful).
6 years, 11 months ago (2014-01-16 00:05:59 UTC) #8
michaelbai
6 years, 11 months ago (2014-01-16 00:16:26 UTC) #9
Message was sent while issue was closed.
On 2014/01/16 00:05:59, aurimas wrote:
> Committed patchset #2 manually as r245022 (presubmit successful).

Did you check the findbug plugin still work?

Powered by Google App Engine
This is Rietveld 408576698