Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1396133003: Stop FaviconHandler from querying GetActiveFaviconValidity() part 1/2 (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_build
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop FaviconHandler from querying GetActiveFaviconValidity() part 1/2 The combination of: - The existence of |FaviconHandler::history_results_| - The checking against duplicate calls to FaviconHandler::OnUpdateFaviconURL() introduced in https://codereview.chromium.org/1295733002 makes the GetActiveFaviconValidity() / GetActiveFaviconURL() check in FaviconHandler::ProcessCurrentUrl() unnecessary BUG=517089 Committed: https://crrev.com/72de4d975e886d4ce0337b28e8613c5d27c53d6f Cr-Commit-Position: refs/heads/master@{#353817}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M components/favicon/core/favicon_handler.cc View 1 chunk +3 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
pkotwicz
Scott, can you please take a look?
5 years, 2 months ago (2015-10-11 03:47:52 UTC) #5
sky
LGTM
5 years, 2 months ago (2015-10-12 15:57:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396133003/20001
5 years, 2 months ago (2015-10-13 14:55:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/81247)
5 years, 2 months ago (2015-10-13 18:04:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396133003/20001
5 years, 2 months ago (2015-10-13 18:16:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 2 months ago (2015-10-13 19:16:50 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 19:17:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72de4d975e886d4ce0337b28e8613c5d27c53d6f
Cr-Commit-Position: refs/heads/master@{#353817}

Powered by Google App Engine
This is Rietveld 408576698