Ignore duplicate FaviconHandler::OnUpdateFaviconURL() calls

Ignore duplicate FaviconHandler::OnUpdateFaviconURL() calls

The renderer sends multiple identical favicon URL updates for a page if the
page starts and stops loading multiple times. This CL makes FaviconHandler
ignore the duplicate updates.

BUG=517089
TEST=FaviconHandlerTest.UpdateSameIconURLs

Committed: https://crrev.com/ab65e6b93624cb054e50456c75397b372b39eef7
Cr-Commit-Position: refs/heads/master@{#353099}

[pkotwicz, 2015-10-05 00:28:03]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2015-10-05 00:39:17]

pkotwicz@chromium.org changed reviewers:
+ sky@chromium.org

[pkotwicz, 2015-10-05 00:39:18]

Scott, can you please take a look?

This is another step towards making FaviconHandler not call
FaviconDriver::GetActiveFaviconValidity() and
FaviconDriver::GetActiveFaviconURL()

[sky, 2015-10-05 15:57:31]

If we want to go to a place where FaviconHandler handles one and only one
request, does this change matter?

[pkotwicz, 2015-10-05 16:02:25]

It does matter. Although we will remove FaviconHandler::FetchFavicon() and make
it the constructor, FaviconHandler::OnUpdateFaviconURL() will stay.

[sky, 2015-10-05 17:22:43]

https://codereview.chromium.org/1295733002/diff/20001/components/favicon/core...
File components/favicon/core/favicon_handler.cc (right):

https://codereview.chromium.org/1295733002/diff/20001/components/favicon/core...
components/favicon/core/favicon_handler.cc:684: std::vector<FaviconURL>*
image_urls) {
Move this into anonymous namespace as it no longer effects state of
FaviconHandler?

[pkotwicz, 2015-10-06 18:39:24]

Patchset #2 (id:40001) has been deleted

[pkotwicz, 2015-10-06 18:40:36]

Scott can you please take another look?

I have moved SortAndPruneImageUrls() into the anonymous namespace as you have
suggested

[sky, 2015-10-06 20:01:50]

LGTM

[pkotwicz, 2015-10-08 17:53:23]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-10-08 17:53:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1295733002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-10-08 17:53:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1295733002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1295733002/80001

[commit-bot: I haz the power, 2015-10-08 18:38:09]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-10-08 18:40:24]

Patchset 3 (id:??) landed as
https://crrev.com/ab65e6b93624cb054e50456c75397b372b39eef7
Cr-Commit-Position: refs/heads/master@{#353099}