Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: components/favicon/core/favicon_handler.cc

Issue 1396133003: Stop FaviconHandler from querying GetActiveFaviconValidity() part 1/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_build
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_handler.cc
diff --git a/components/favicon/core/favicon_handler.cc b/components/favicon/core/favicon_handler.cc
index aea23c5e7415086ab53d7f60925c0d7e9f1e3108..d8ec1eaa58ad193058466179d9994f3914679129 100644
--- a/components/favicon/core/favicon_handler.cc
+++ b/components/favicon/core/favicon_handler.cc
@@ -384,17 +384,9 @@ void FaviconHandler::OnUpdateFaviconURL(
void FaviconHandler::ProcessCurrentUrl() {
DCHECK(!image_urls_.empty());
- if (current_candidate()->icon_type == favicon_base::FAVICON &&
- !download_largest_icon_) {
- if (!favicon_expired_or_incomplete_ &&
- driver_->GetActiveFaviconValidity() &&
- DoUrlAndIconMatch(*current_candidate(),
- driver_->GetActiveFaviconURL(),
- favicon_base::FAVICON))
- return;
- } else if (!favicon_expired_or_incomplete_ && got_favicon_from_history_ &&
- HasValidResult(history_results_) &&
- DoUrlsAndIconsMatch(*current_candidate(), history_results_)) {
+ if (!favicon_expired_or_incomplete_ && got_favicon_from_history_ &&
+ HasValidResult(history_results_) &&
+ DoUrlsAndIconsMatch(*current_candidate(), history_results_)) {
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698