Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394803004: Don't use base::MessageLoop::{Quit,QuitClosure} in remoting/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
Reviewers:
joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in remoting/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=joedow@chromium.org Committed: https://crrev.com/659c758f070333905acee302474fb4bc2ce1ba46 Cr-Commit-Position: refs/heads/master@{#353583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -47 lines) Patch
M remoting/base/auto_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/auto_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/base/auto_thread_task_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/auto_thread_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/client_status_logger_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/jni/chromoting_jni_runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/daemon_process_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_change_notification_listener_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/host_status_logger_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/token_validator_factory_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/authenticator_test_base.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/protocol/channel_multiplexer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/connection_tester.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/monitored_video_stub_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M remoting/protocol/pseudotcp_adapter_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M remoting/signaling/iq_sender_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
ki.stfu
5 years, 2 months ago (2015-10-09 19:09:48 UTC) #1
ki.stfu
ping
5 years, 2 months ago (2015-10-12 13:41:57 UTC) #2
joedow
lgtm
5 years, 2 months ago (2015-10-12 19:05:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394803004/1
5 years, 2 months ago (2015-10-12 19:06:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 20:10:15 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 20:11:06 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/659c758f070333905acee302474fb4bc2ce1ba46
Cr-Commit-Position: refs/heads/master@{#353583}

Powered by Google App Engine
This is Rietveld 408576698