Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: remoting/protocol/monitored_video_stub_unittest.cc

Issue 1394803004: Don't use base::MessageLoop::{Quit,QuitClosure} in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/jingle_session_unittest.cc ('k') | remoting/protocol/pseudotcp_adapter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/monitored_video_stub_unittest.cc
diff --git a/remoting/protocol/monitored_video_stub_unittest.cc b/remoting/protocol/monitored_video_stub_unittest.cc
index 448785a0313c581bfa894ef6f690420410eee47f..58db106521fa677f8560b71d92042ecf888ba6ff 100644
--- a/remoting/protocol/monitored_video_stub_unittest.cc
+++ b/remoting/protocol/monitored_video_stub_unittest.cc
@@ -58,10 +58,9 @@ TEST_F(MonitoredVideoStubTest, OnChannelDisconnected) {
EXPECT_CALL(*this, OnVideoChannelStatus(true));
monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
- EXPECT_CALL(*this, OnVideoChannelStatus(false)).WillOnce(
- InvokeWithoutArgs(
- &message_loop_,
- &base::MessageLoop::Quit));
+ EXPECT_CALL(*this, OnVideoChannelStatus(false))
+ .WillOnce(
+ InvokeWithoutArgs(&message_loop_, &base::MessageLoop::QuitWhenIdle));
message_loop_.Run();
}
@@ -86,8 +85,7 @@ TEST_F(MonitoredVideoStubTest, OnChannelStayDisconnected) {
monitor_->ProcessVideoPacket(packet_.Pass(), base::Closure());
message_loop_.PostDelayedTask(
- FROM_HERE,
- base::MessageLoop::QuitClosure(),
+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),
// The delay should be much greater than |kTestOverrideDelayMilliseconds|.
TestTimeouts::tiny_timeout());
message_loop_.Run();
« no previous file with comments | « remoting/protocol/jingle_session_unittest.cc ('k') | remoting/protocol/pseudotcp_adapter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698