Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: remoting/protocol/authenticator_test_base.cc

Issue 1394803004: Don't use base::MessageLoop::{Quit,QuitClosure} in remoting/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/authenticator_test_base.cc
diff --git a/remoting/protocol/authenticator_test_base.cc b/remoting/protocol/authenticator_test_base.cc
index eb3d6bd8bdce910f4303d8cc4ef88d2dbfcccd10..f2166d79380eb842d3da05b17da31dc4318607a7 100644
--- a/remoting/protocol/authenticator_test_base.cc
+++ b/remoting/protocol/authenticator_test_base.cc
@@ -31,7 +31,7 @@ ACTION_P(QuitThreadOnCounter, counter) {
--(*counter);
EXPECT_GE(*counter, 0);
if (*counter == 0)
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
} // namespace
@@ -142,9 +142,8 @@ void AuthenticatorTestBase::RunChannelAuth(bool expected_fail) {
// Ensure that .Run() does not run unbounded if the callbacks are never
// called.
base::Timer shutdown_timer(false, false);
- shutdown_timer.Start(FROM_HERE,
- TestTimeouts::action_timeout(),
- base::MessageLoop::QuitClosure());
+ shutdown_timer.Start(FROM_HERE, TestTimeouts::action_timeout(),
+ base::MessageLoop::QuitWhenIdleClosure());
message_loop_.Run();
shutdown_timer.Stop();
« no previous file with comments | « remoting/host/win/worker_process_launcher_unittest.cc ('k') | remoting/protocol/channel_multiplexer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698