Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394723002: This CL fixes the issue with login using alternative e-mails. (Closed)

Created:
5 years, 2 months ago by Alexander Alekseev
Modified:
5 years, 2 months ago
Reviewers:
achuithb
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

This CL fixes the issue with login using alternative e-mails. If new user is added, we lookup if it already exists by e-mail. This CL also adds lookup by gaia_id, and adds gaia_id support for telemetry test API. BUG=535369 TEST=manual Committed: https://crrev.com/0f37b696b7a814d4157401c304643594a4ae9731 Cr-Commit-Position: refs/heads/master@{#351482} Review URL: https://codereview.chromium.org/1370913002 Cr-Commit-Position: refs/heads/master@{#352574} (cherry picked from commit b3b38a1ef3e858d0f8dc0b2c2ea96aabb9688647) TBR=achuith@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/bf56b1cf0375dfa19c94ccbd245912be8ad43c12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -15 lines) Patch
M chrome/browser/chromeos/login/signin/device_id_browsertest.cc View 8 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/login_common.js View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 3 chunks +28 lines, -2 lines 0 comments Download
M components/user_manager/user_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py View 2 chunks +7 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/cros_test_case.py View 2 chunks +5 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/backends/chrome/oobe.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/browser_options.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexander Alekseev
Committed patchset #1 (id:1) manually as bf56b1cf0375dfa19c94ccbd245912be8ad43c12 (presubmit successful).
5 years, 2 months ago (2015-10-08 00:15:23 UTC) #1
achuithb
5 years, 2 months ago (2015-10-08 00:22:01 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698