Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py

Issue 1394723002: This CL fixes the issue with login using alternative e-mails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2526
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
diff --git a/tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
index 42cc73b9691d0e681dee7d3d5922819c03c23492..6df641f473a213fd4780ca5e10a4155d0ca7a248 100644
--- a/tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
+++ b/tools/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py
@@ -139,7 +139,9 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
elif self.browser_options.gaia_login:
self.oobe.NavigateGaiaLogin(self._username, self._password)
else:
- self.oobe.NavigateFakeLogin(self._username, self._password)
+ self.oobe.NavigateFakeLogin(self._username, self._password,
+ self._gaia_id)
+
self._WaitForLogin()
except exceptions.TimeoutException:
raise exceptions.LoginException('Timed out going through login screen')
@@ -196,6 +198,10 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
def _password(self):
return self.browser_options.password
+ @property
+ def _gaia_id(self):
+ return self.browser_options.gaia_id
+
def _IsCryptohomeMounted(self):
username = '$guest' if self._is_guest else self._username
return self._cri.IsCryptohomeMounted(username, self._is_guest)
« no previous file with comments | « components/user_manager/user_manager_base.cc ('k') | tools/telemetry/telemetry/internal/backends/chrome/cros_test_case.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698