Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome/cros_test_case.py

Issue 1394723002: This CL fixes the issue with login using alternative e-mails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2526
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/internal/backends/chrome/cros_test_case.py
diff --git a/tools/telemetry/telemetry/internal/backends/chrome/cros_test_case.py b/tools/telemetry/telemetry/internal/backends/chrome/cros_test_case.py
index f86aac7fc972df13f394f268c22f2de29e36057b..eabe9b6c0ead3eecd8ff1834c70b474df5e9e04c 100644
--- a/tools/telemetry/telemetry/internal/backends/chrome/cros_test_case.py
+++ b/tools/telemetry/telemetry/internal/backends/chrome/cros_test_case.py
@@ -21,10 +21,12 @@ class CrOSTestCase(unittest.TestCase):
self._is_guest = options.browser_type == 'cros-chrome-guest'
self._username = options.browser_options.username
self._password = options.browser_options.password
+ self._gaia_id = options.browser_options.gaia_id
self._load_extension = None
def _CreateBrowser(self, autotest_ext=False, auto_login=True,
- gaia_login=False, username=None, password=None):
+ gaia_login=False, username=None, password=None,
+ gaia_id=None):
"""Finds and creates a browser for tests. if autotest_ext is True,
also loads the autotest extension"""
options = options_for_unittests.GetCopy()
@@ -48,6 +50,8 @@ class CrOSTestCase(unittest.TestCase):
browser_options.username = username
if password is not None:
browser_options.password = password
+ if gaia_id is not None:
+ browser_options.gaia_id = gaia_id
return browser_to_create.Create(options)

Powered by Google App Engine
This is Rietveld 408576698