chrome/browser/resources/chromeos/login/login_common.js - Issue 1394723002: This CL fixes the issue with login using alternative e-mails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/login_common.js

Issue 1394723002: This CL fixes the issue with login using alternative e-mails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2526

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/test/oobe_base_test.cc ('k') | chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/login_common.js

diff --git a/chrome/browser/resources/chromeos/login/login_common.js b/chrome/browser/resources/chromeos/login/login_common.js

index e9cca699535237ab29f3e56573149e2ab5b17299..dc9fa54e91e3f43f874b66e1ecf4a1d0de63dd40 100644

--- a/chrome/browser/resources/chromeos/login/login_common.js

+++ b/chrome/browser/resources/chromeos/login/login_common.js

@@ -285,10 +285,16 @@ cr.define('cr.ui', function() {

* @param {string} username Login username.

* @param {string} password Login password.

- Oobe.loginForTesting = function(username, password) {

+ Oobe.loginForTesting = function(username, password, gaia_id) {

Oobe.disableSigninUI();

chrome.send('skipToLoginForTesting', [username]);

- chrome.send('completeLogin', ['12345', username, password, false]);

+ if (!gaia_id) {

+ /* TODO (alemate): Remove this backward compatibility hack when

+ as soon as all telemetry tests will pass gaia_id directly.

+ */

+ gaia_id = '12345';

+ }

+ chrome.send('completeLogin', [gaia_id, username, password, false]);

};

/**