Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1394303004: Move //mojo/services/X/public/... to //mojo/services/X/... (part 3). (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@no_public_2-x-no_public_1
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move //mojo/services/X/public/... to //mojo/services/X/... (part 3). X = navigation, nfc, notifications, ozone_drm_gpu, ozone_drm_host, prediction, sensors, service_registry, sharing, speech_recognizer, surfaces, terminal, tracing, url_response_disk_cache (Skipped network.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0f4f3ba26f261ad8c556a8ce13a6ca3fa2d1b2af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -1340 lines) Patch
M apps/benchmark/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M apps/benchmark/README.md View 1 chunk +1 line, -1 line 0 comments Download
M apps/benchmark/benchmark_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/benchmark/trace_collector_client.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/BUILD.gn View 4 chunks +7 lines, -7 lines 0 comments Download
M apps/moterm/README.md View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/gl_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/moterm/gl_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/gl_helper_test_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M apps/moterm/gl_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/moterm_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/moterm/moterm_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/bitmap_uploader/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/echo_terminal/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/echo_terminal/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/embedded_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/embedded_app/embedded_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/ganesh_app/ganesh_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/texture_uploader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/ganesh_app/texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/js/repl.js View 1 chunk +1 line, -1 line 0 comments Download
M examples/keyboard_client/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/moterm_example_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/moterm_example_app/moterm_example_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/native_run_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/native_run_app/native_run_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/nesting_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/nfc_sender/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/nfc_sender/nfc_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/notification_generator/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/notification_generator/notification_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/BUILD.gn View 4 chunks +7 lines, -7 lines 0 comments Download
M examples/surfaces_app/child.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_gl_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_gl_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/embedder.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/surfaces_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/window_manager/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/window_manager/debug_panel.sky View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/debug_panel_host.mojom View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/trace_provider_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/tracing_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/ozone_drm_gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/ozone_drm_gpu/ozone_drm_gpu_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/devtools/common/docs/mojo_benchmark.md View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/gpu/texture_cache.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/texture_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/texture_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/texture_uploader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/mojo_services.gni View 1 chunk +14 lines, -14 lines 0 comments Download
M mojo/services/native_viewport/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/navigation/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/navigation/interfaces/navigation.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/navigation/public/interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/navigation/public/interfaces/navigation.mojom View 1 chunk +0 lines, -30 lines 0 comments Download
A + mojo/services/nfc/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/nfc/interfaces/nfc.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/nfc/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/nfc/public/interfaces/nfc.mojom View 1 chunk +0 lines, -43 lines 0 comments Download
A + mojo/services/notifications/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/notifications/interfaces/notifications.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/notifications/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/notifications/public/interfaces/notifications.mojom View 1 chunk +0 lines, -44 lines 0 comments Download
A + mojo/services/ozone_drm_gpu/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/ozone_drm_gpu/interfaces/ozone_drm_gpu.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/ozone_drm_gpu/public/interfaces/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/services/ozone_drm_gpu/public/interfaces/ozone_drm_gpu.mojom View 1 chunk +0 lines, -54 lines 0 comments Download
A + mojo/services/ozone_drm_host/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/ozone_drm_host/interfaces/ozone_drm_host.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/ozone_drm_host/public/interfaces/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/services/ozone_drm_host/public/interfaces/ozone_drm_host.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
A + mojo/services/prediction/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/prediction/interfaces/prediction.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/prediction/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/prediction/public/interfaces/prediction.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
A + mojo/services/sensors/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/sensors/interfaces/sensors.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/sensors/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/sensors/public/interfaces/sensors.mojom View 1 chunk +0 lines, -43 lines 0 comments Download
A + mojo/services/service_registry/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/service_registry/interfaces/service_registry.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/service_registry/public/interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/service_registry/public/interfaces/service_registry.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
A + mojo/services/sharing/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/sharing/interfaces/sharing.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/sharing/public/interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/sharing/public/interfaces/sharing.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
A + mojo/services/speech_recognizer/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/speech_recognizer/interfaces/speech_recognizer.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/speech_recognizer/public/interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/speech_recognizer/public/interfaces/speech_recognizer.mojom View 1 chunk +0 lines, -45 lines 0 comments Download
A + mojo/services/surfaces/cpp/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/surfaces/cpp/surfaces_utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/surfaces/cpp/surfaces_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/surfaces/interfaces/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/surfaces/interfaces/display.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/surfaces/interfaces/quads.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/surfaces/interfaces/surface_id.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/surfaces/interfaces/surfaces.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
D mojo/services/surfaces/public/cpp/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/surfaces/public/cpp/surfaces_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/services/surfaces/public/cpp/surfaces_utils.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/services/surfaces/public/interfaces/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D mojo/services/surfaces/public/interfaces/display.mojom View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/services/surfaces/public/interfaces/quads.mojom View 1 chunk +0 lines, -213 lines 0 comments Download
D mojo/services/surfaces/public/interfaces/surface_id.mojom View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/services/surfaces/public/interfaces/surfaces.mojom View 1 chunk +0 lines, -78 lines 0 comments Download
A + mojo/services/terminal/interfaces/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/terminal/interfaces/terminal.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/terminal/interfaces/terminal_client.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/terminal/public/interfaces/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/services/terminal/public/interfaces/terminal.mojom View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/terminal/public/interfaces/terminal_client.mojom View 1 chunk +0 lines, -16 lines 0 comments Download
A + mojo/services/tracing/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/tracing/interfaces/tracing.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/tracing/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/tracing/public/interfaces/tracing.mojom View 1 chunk +0 lines, -32 lines 0 comments Download
A + mojo/services/url_response_disk_cache/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/url_response_disk_cache/interfaces/url_response_disk_cache.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/url_response_disk_cache/public/interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/url_response_disk_cache/public/interfaces/url_response_disk_cache.mojom View 1 chunk +0 lines, -60 lines 0 comments Download
M mojo/services/view_manager/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/cpp/view.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/android/java_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/dart/dart_tracing.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/debugger/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/debugger/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/fake_surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/fake_surfaces/fake_surfaces_service_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/fake_surfaces/fake_surfaces_service_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/keyboard_native/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M services/keyboard_native/predictor.h View 1 chunk +1 line, -1 line 0 comments Download
M services/keyboard_native/view_observer_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/kiosk_wm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/kiosk_wm/kiosk_wm_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M services/kiosk_wm/merged_service_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M services/kiosk_wm/navigator_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/notifications/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/notifications/apptests/notifications_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/prediction/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/dictionary_service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/dictionary_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/input_info.h View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/key_set.h View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/prediction_apptests.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/prediction_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/proximity_info_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M services/prediction/touch_position_correction.h View 1 chunk +1 line, -1 line 0 comments Download
M services/sensors/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/sharing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/speech_recognizer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/display_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/display_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/surfaces_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/surfaces_service_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/trace_recorder_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/tracing/tracing_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/display_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/display_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/view_manager/view_manager_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M shell/android/android_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/nfc_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/application_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/network_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/context.cc View 1 chunk +1 line, -1 line 0 comments Download
M shell/tracer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/mojo/drm_gpu_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/mojo/drm_gpu_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/mojo/drm_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/mojo/drm_host_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/mojo/drm_ipc_init_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-09 22:27:59 UTC) #1
jamesr
rs lgtm
5 years, 2 months ago (2015-10-09 22:55:04 UTC) #2
viettrungluu
5 years, 2 months ago (2015-10-10 08:08:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0f4f3ba26f261ad8c556a8ce13a6ca3fa2d1b2af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698