Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1391243003: Move //mojo/services/X/public/... to //mojo/services/X/... (part 4). (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@no_public_3-x-no_public_2-x-no_public_1
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move //mojo/services/X/public/... to //mojo/services/X/... (part 4). X = vanadium/security, view_manager, window_manager (This is the last one, except for network, which is pulled from monet.) R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/15a59a82d9e5e7ee4157f082e53ca92026ee8d1a

Patch Set 1 #

Patch Set 2 : copyright header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -4287 lines) Patch
M apps/moterm/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/moterm_main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M apps/moterm/moterm_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/bank_app/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/bank_app/bank.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/bank_app/customer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/bitmap_uploader/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/browser/browser.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M examples/embedded_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/embedded_app/embedded_app.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M examples/ganesh_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/ganesh_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/ganesh_app/ganesh_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/js/show_image.js View 1 2 chunks +5 lines, -1 line 0 comments Download
M examples/keyboard_client/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/keyboard_client/keyboard_client.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M examples/moterm_example_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/moterm_example_app/moterm_example_app.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M examples/nesting_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/nesting_app/nesting_app.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M examples/nfc_sender/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/nfc_sender/nfc_sender.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/pdf_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/pdf_viewer/pdf_viewer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M examples/png_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/png_viewer.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M examples/window_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/window_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/wm_flow/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M examples/wm_flow/app/app.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M examples/wm_flow/embedded/embedded.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/wm/frame_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wm_flow/wm/wm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/mojo_services.gni View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/vanadium/security/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/vanadium/security/interfaces/principal.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/vanadium/security/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/vanadium/security/public/interfaces/principal.mojom View 1 chunk +0 lines, -49 lines 0 comments Download
A + mojo/services/view_manager/cpp/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
A + mojo/services/view_manager/cpp/keys.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/cpp/keys.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/cpp/lib/view.cc View 14 chunks +34 lines, -53 lines 0 comments Download
A + mojo/services/view_manager/cpp/lib/view_manager_client_factory.cc View 1 chunk +4 lines, -6 lines 0 comments Download
A + mojo/services/view_manager/cpp/lib/view_manager_client_impl.h View 2 chunks +8 lines, -8 lines 0 comments Download
A + mojo/services/view_manager/cpp/lib/view_manager_client_impl.cc View 9 chunks +22 lines, -34 lines 0 comments Download
A + mojo/services/view_manager/cpp/lib/view_manager_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/view_manager/cpp/lib/view_observer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/cpp/lib/view_private.h View 4 chunks +9 lines, -18 lines 0 comments Download
A + mojo/services/view_manager/cpp/lib/view_private.cc View 1 chunk +3 lines, -5 lines 0 comments Download
A + mojo/services/view_manager/cpp/tests/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/cpp/tests/run_all_unittests.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A + mojo/services/view_manager/cpp/tests/view_manager_test_suite.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/view_manager/cpp/tests/view_manager_test_suite.cc View 2 chunks +2 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/cpp/tests/view_unittest.cc View 9 chunks +27 lines, -37 lines 0 comments Download
A + mojo/services/view_manager/cpp/types.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/cpp/util.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/cpp/view.h View 3 chunks +6 lines, -6 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_manager_client_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_manager_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_manager_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/cpp/view_observer.h View 3 chunks +7 lines, -8 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_property.h View 3 chunks +5 lines, -6 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_tracker.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/view_manager/cpp/view_tracker.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + mojo/services/view_manager/interfaces/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/view_manager/interfaces/animations.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/view_manager/interfaces/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/view_manager/interfaces/view_manager_constants.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/view_manager/public/cpp/BUILD.gn View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/services/view_manager/public/cpp/keys.h View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/view_manager/public/cpp/keys.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/view_manager/public/cpp/lib/view.cc View 1 chunk +0 lines, -602 lines 0 comments Download
D mojo/services/view_manager/public/cpp/lib/view_manager_client_factory.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.h View 1 chunk +0 lines, -164 lines 0 comments Download
D mojo/services/view_manager/public/cpp/lib/view_manager_client_impl.cc View 1 chunk +0 lines, -506 lines 0 comments Download
D mojo/services/view_manager/public/cpp/lib/view_manager_context.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/services/view_manager/public/cpp/lib/view_observer.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/services/view_manager/public/cpp/lib/view_private.h View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/services/view_manager/public/cpp/lib/view_private.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/services/view_manager/public/cpp/tests/BUILD.gn View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/services/view_manager/public/cpp/tests/run_all_unittests.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/view_manager/public/cpp/tests/view_manager_test_suite.h View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/services/view_manager/public/cpp/tests/view_manager_test_suite.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/services/view_manager/public/cpp/tests/view_unittest.cc View 1 chunk +0 lines, -884 lines 0 comments Download
D mojo/services/view_manager/public/cpp/types.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/view_manager/public/cpp/util.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view.h View 1 chunk +0 lines, -214 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_manager.h View 1 chunk +0 lines, -42 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_manager_client_factory.h View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_manager_context.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_manager_delegate.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_manager_delegate.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_observer.h View 1 chunk +0 lines, -106 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_property.h View 1 chunk +0 lines, -140 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_tracker.h View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/services/view_manager/public/cpp/view_tracker.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/services/view_manager/public/interfaces/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/view_manager/public/interfaces/animations.mojom View 1 chunk +0 lines, -62 lines 0 comments Download
D mojo/services/view_manager/public/interfaces/view_manager.mojom View 1 chunk +0 lines, -231 lines 0 comments Download
D mojo/services/view_manager/public/interfaces/view_manager_constants.mojom View 1 chunk +0 lines, -11 lines 0 comments Download
A + mojo/services/window_manager/interfaces/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/window_manager/interfaces/window_manager.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/window_manager/interfaces/window_manager_internal.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/window_manager/public/interfaces/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/services/window_manager/public/interfaces/window_manager.mojom View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/services/window_manager/public/interfaces/window_manager_internal.mojom View 1 chunk +0 lines, -40 lines 0 comments Download
M services/debugger/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/debugger/debugger.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/keyboard_native/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/keyboard_native/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/keyboard_native/view_observer_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/kiosk_wm/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M services/kiosk_wm/kiosk_wm.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/kiosk_wm/kiosk_wm_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/vanadium/security/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/vanadium/security/principal_service.go View 1 chunk +1 line, -1 line 0 comments Download
M services/vanadium/security/wire_blessings.go View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/BUILD.gn View 7 chunks +16 lines, -16 lines 0 comments Download
M services/view_manager/access_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/animation_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/client_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/connection_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/connection_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/display_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/gesture_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/gesture_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/gesture_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/ids.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/scheduled_animation_group.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/scheduled_animation_group_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/server_view.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/server_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/server_view_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/test_change_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/test_change_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_client_apptest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M services/view_manager/view_manager_root_connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/view_manager_service_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/view_manager/view_manager_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/view_manager/view_manager_service_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M services/window_manager/BUILD.gn View 4 chunks +8 lines, -8 lines 0 comments Download
M services/window_manager/basic_focus_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/capture_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/capture_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/focus_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/focus_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/focus_rules.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/view_event_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/view_target.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/view_target_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/window_manager_apptest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/window_manager/window_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/window_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/window_manager/window_manager_root.h View 1 chunk +5 lines, -5 lines 0 comments Download
M services/window_manager/window_manager_root.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/window_manager_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-09 22:51:57 UTC) #1
jamesr
rs lgtm
5 years, 2 months ago (2015-10-09 23:00:00 UTC) #2
viettrungluu
5 years, 2 months ago (2015-10-10 08:11:05 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
15a59a82d9e5e7ee4157f082e53ca92026ee8d1a.

Powered by Google App Engine
This is Rietveld 408576698