[net/http auth] Split HttpAuthHandler creation from initialization.

net/http/http_auth_handler_basic_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 17 matching lines @@
     { "", "foobar", "Basic OmZvb2Jhcg==" },
     // Empty password
     { "anon", "", "Basic YW5vbjo=" },
     // Empty username and empty password.
     { "", "", "Basic Og==" },
   };
   GURL origin("http://www.example.com");
   HttpAuthHandlerBasic::Factory factory;
   for (size_t i = 0; i < arraysize(tests); ++i) {
     std::string challenge = "Basic realm=\"Atlantis\"";
-    scoped_ptr<HttpAuthHandler> basic;
-    EXPECT_EQ(OK, factory.CreateAuthHandlerFromString(
-        challenge, HttpAuth::AUTH_SERVER, origin, BoundNetLog(), &basic));
+    scoped_ptr<HttpAuthHandler> basic =
+        factory.CreateAuthHandlerForScheme("basic");
+    ASSERT_TRUE(basic);
+    HttpAuthChallengeTokenizer tokenizer(challenge.begin(), challenge.end());
+    EXPECT_EQ(OK, basic->HandleInitialChallenge(
+                      tokenizer, HttpAuth::AUTH_SERVER, origin, BoundNetLog()));
     AuthCredentials credentials(base::ASCIIToUTF16(tests[i].username),
                                 base::ASCIIToUTF16(tests[i].password));
     HttpRequestInfo request_info;
     std::string auth_token;
     TestCompletionCallback callback;
     int rv = basic->GenerateAuthToken(&credentials, request_info,
                                       callback.callback(), &auth_token);
     EXPECT_EQ(OK, rv);
     EXPECT_STREQ(tests[i].expected_credentials, auth_token.c_str());
   }
@@ skipping 29 matching lines @@
 
     // And this one should be treated as if it was for "Second."
     {
       "basic realm=\"First\",realm=\"Second\"",
       HttpAuth::AUTHORIZATION_RESULT_DIFFERENT_REALM
     }
   };
 
   GURL origin("http://www.example.com");
   HttpAuthHandlerBasic::Factory factory;
-  scoped_ptr<HttpAuthHandler> basic;
-  EXPECT_EQ(OK, factory.CreateAuthHandlerFromString(
-      tests[0].challenge, HttpAuth::AUTH_SERVER, origin,
-      BoundNetLog(), &basic));
+  scoped_ptr<HttpAuthHandler> basic =
+      factory.CreateAuthHandlerForScheme("basic");
+  std::string initial_challenge(tests[0].challenge);
+  HttpAuthChallengeTokenizer tokenizer(initial_challenge.begin(),
+                                       initial_challenge.end());
+  EXPECT_EQ(OK, basic->HandleInitialChallenge(tokenizer, HttpAuth::AUTH_SERVER,
+                                              origin, BoundNetLog()));
 
   for (size_t i = 0; i < arraysize(tests); ++i) {
     std::string challenge(tests[i].challenge);
     HttpAuthChallengeTokenizer tok(challenge.begin(),
                                    challenge.end());
     EXPECT_EQ(tests[i].expected_rv, basic->HandleAnotherChallenge(tok));
   }
 }
 
 TEST(HttpAuthHandlerBasicTest, HandleInitialChallenge) {
@@ skipping 49 matching lines @@
     },
 
     // The parser skips over tokens which aren't known.
     {
       "Basic unknown_token=foobar realm=\"test_realm\"",
       OK,
       "test_realm",
     },
 #endif
 
-    // The parser fails when the first token is not "Basic".
-    {
-      "Negotiate",
-      ERR_INVALID_RESPONSE,
-      ""
-    },
-
     // Although RFC 2617 isn't explicit about this case, if there is
     // more than one realm directive, we pick the last one.
     {
       "Basic realm=\"foo\",realm=\"bar\"",
       OK,
       "bar",
     },
 
     // Handle ISO-8859-1 character as part of the realm. The realm is converted
     // to UTF-8.
     {
       "Basic realm=\"foo-\xE5\"",
       OK,
       "foo-\xC3\xA5",
     },
   };
   HttpAuthHandlerBasic::Factory factory;
   GURL origin("http://www.example.com");
   for (size_t i = 0; i < arraysize(tests); ++i) {
     std::string challenge = tests[i].challenge;
-    scoped_ptr<HttpAuthHandler> basic;
-    int rv = factory.CreateAuthHandlerFromString(
-        challenge, HttpAuth::AUTH_SERVER, origin, BoundNetLog(), &basic);
+    scoped_ptr<HttpAuthHandler> basic =
+        factory.CreateAuthHandlerForScheme("basic");
+    HttpAuthChallengeTokenizer tokenizer(challenge.begin(), challenge.end());
+    int rv = basic->HandleInitialChallenge(tokenizer, HttpAuth::AUTH_SERVER,
+                                           origin, BoundNetLog());
     EXPECT_EQ(tests[i].expected_rv, rv);
     if (rv == OK)
       EXPECT_EQ(tests[i].expected_realm, basic->realm());
   }
 }
 
+TEST(HttpAuthHandlerBasicTest, CreateAuthHandlerForScheme) {
+  HttpAuthHandlerBasic::Factory basic_factory;
+
+  EXPECT_TRUE(basic_factory.CreateAuthHandlerForScheme("basic"));
+  EXPECT_FALSE(basic_factory.CreateAuthHandlerForScheme("bogus"));
+}
+
+TEST(HttpAuthHandlerBasicTest, CreateAndInitPreemptiveAuthHandler_Valid) {
+  HttpAuthHandlerBasic::Factory digest_factory;
+  HttpAuthCache auth_cache;
+  std::string challenge("basic realm=\"Foo\"");
+  HttpAuthChallengeTokenizer tokenizer(challenge.begin(), challenge.end());
+
+  HttpAuthCache::Entry* entry =
+      auth_cache.Add(GURL("http://example.com/foo").GetOrigin(), "foo", "basic",
+                     challenge, AuthCredentials(), "/foo");
+  EXPECT_TRUE(digest_factory.CreateAndInitPreemptiveAuthHandler(
+      entry, tokenizer, HttpAuth::AUTH_SERVER, BoundNetLog()));
+}
+
+TEST(HttpAuthHandlerBasicTest, CreateAndInitPreemptiveAuthHandler_Invalid) {
+  HttpAuthHandlerBasic::Factory digest_factory;
+  HttpAuthCache auth_cache;
+  std::string challenge("digest realm=\"foo\"");
+  HttpAuthChallengeTokenizer tokenizer(challenge.begin(), challenge.end());
+
+  HttpAuthCache::Entry* entry =
+      auth_cache.Add(GURL("http://example.com").GetOrigin(), "bar", "digest",
+                     challenge, AuthCredentials(), "/bar");
+  EXPECT_FALSE(digest_factory.CreateAndInitPreemptiveAuthHandler(
+      entry, tokenizer, HttpAuth::AUTH_SERVER, BoundNetLog()));
+}
+
 }  // namespace net