Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: net/http/http_auth_handler_ntlm.cc

Issue 1393693002: [net/http auth] Split HttpAuthHandler creation from initialization. Base URL: https://chromium.googlesource.com/chromium/src.git@rename-auth-handler-methods
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_ntlm.h ('k') | net/http/http_auth_handler_ntlm_portable.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_ntlm.cc
diff --git a/net/http/http_auth_handler_ntlm.cc b/net/http/http_auth_handler_ntlm.cc
index 378991fb82e0d646daa3361e0d54d8706a868632..c866598707f173ecd0e2f687ee8bc86f7c22a11a 100644
--- a/net/http/http_auth_handler_ntlm.cc
+++ b/net/http/http_auth_handler_ntlm.cc
@@ -22,7 +22,6 @@ HttpAuth::AuthorizationResult HttpAuthHandlerNTLM::HandleAnotherChallenge(
}
int HttpAuthHandlerNTLM::Init(const HttpAuthChallengeTokenizer& tok) {
- auth_scheme_ = "ntlm";
return ParseChallenge(tok, true) == HttpAuth::AUTHORIZATION_RESULT_ACCEPT
? OK
: ERR_INVALID_RESPONSE;
@@ -102,6 +101,7 @@ int HttpAuthHandlerNTLM::GenerateAuthTokenImpl(
HttpAuth::AuthorizationResult HttpAuthHandlerNTLM::ParseChallenge(
const HttpAuthChallengeTokenizer& tok,
bool initial_challenge) {
+ DCHECK(tok.SchemeIs("ntlm"));
#if defined(NTLM_SSPI)
// auth_sspi_ contains state for whether or not this is the initial challenge.
return auth_sspi_.ParseChallenge(tok);
@@ -141,4 +141,14 @@ std::string HttpAuthHandlerNTLM::CreateSPN(const GURL& origin) {
return target;
}
+// None of the implementations support pre-emptive authentication for NTLM.
+scoped_ptr<HttpAuthHandler>
+HttpAuthHandlerNTLM::Factory::CreateAndInitPreemptiveAuthHandler(
+ HttpAuthCache::Entry* cache_entry,
+ const HttpAuthChallengeTokenizer& tokenizer,
+ HttpAuth::Target target,
+ const BoundNetLog& net_log) {
+ return scoped_ptr<HttpAuthHandler>();
+}
+
} // namespace net
« no previous file with comments | « net/http/http_auth_handler_ntlm.h ('k') | net/http/http_auth_handler_ntlm_portable.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698