Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139303007: Deprecate the TextTrackCue constructor (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : rebase and revert incorrect test change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M LayoutTests/media/track/text-track-cue-constructor-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8TextTrackCueCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-16 04:00:30 UTC) #1
tkent
lgtm
6 years, 11 months ago (2014-01-16 04:04:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139303007/1
6 years, 11 months ago (2014-01-16 04:04:41 UTC) #3
haraken
LGTM for bindings/
6 years, 11 months ago (2014-01-16 04:05:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139303007/100001
6 years, 11 months ago (2014-01-16 04:33:47 UTC) #5
philipj_slow
Oops, not so fast. The LayoutTests/media/track/text-track-cue-exceptions.html should be updated to use VTTCue instead, I'll do ...
6 years, 11 months ago (2014-01-16 04:39:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139303007/150001
6 years, 11 months ago (2014-01-16 06:59:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) wtf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7692
6 years, 11 months ago (2014-01-16 07:45:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139303007/150001
6 years, 11 months ago (2014-01-16 07:57:25 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) wtf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7714
6 years, 11 months ago (2014-01-16 08:59:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139303007/150001
6 years, 11 months ago (2014-01-16 11:25:35 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) wtf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7765
6 years, 11 months ago (2014-01-16 12:03:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/139303007/150001
6 years, 11 months ago (2014-01-16 16:08:34 UTC) #13
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 16:23:55 UTC) #14
Message was sent while issue was closed. 
Change committed as 165234

Powered by Google App Engine
This is Rietveld 408576698