Source/bindings/v8/custom/V8TextTrackCueCustom.cpp - Issue 139303007: Deprecate the TextTrackCue constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

Issue 139303007: Deprecate the TextTrackCue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase and revert incorrect test change Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

diff --git a/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp b/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

index 3adef38297e74537479463be5932b8992fdd7ed2..221e9b22a25eb313fe5383b914a7f45d4fe1fcde 100644

--- a/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

+++ b/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

@@ -58,7 +58,7 @@ void V8TextTrackCue::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, text, info[2]);

Document& document = *toDocument(getExecutionContext());

- UseCounter::count(document, UseCounter::TextTrackCueConstructor);

+ UseCounter::countDeprecation(document, UseCounter::TextTrackCueConstructor);

RefPtr<VTTCue> impl = VTTCue::create(document, startTime, endTime, text);

v8::Handle<v8::Object> wrapper = wrap(impl.get(), info.Holder(), info.GetIsolate());