Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/bindings/v8/custom/V8TextTrackCueCustom.cpp

Issue 139303007: Deprecate the TextTrackCue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase and revert incorrect test change Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Opera Software ASA. All rights reserved. 2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 if (UNLIKELY(info.Length() < 3)) { 51 if (UNLIKELY(info.Length() < 3)) {
52 exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(3, i nfo.Length())); 52 exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(3, i nfo.Length()));
53 exceptionState.throwIfNeeded(); 53 exceptionState.throwIfNeeded();
54 return; 54 return;
55 } 55 }
56 V8TRYCATCH_VOID(double, startTime, static_cast<double>(info[0]->NumberValue( ))); 56 V8TRYCATCH_VOID(double, startTime, static_cast<double>(info[0]->NumberValue( )));
57 V8TRYCATCH_VOID(double, endTime, static_cast<double>(info[1]->NumberValue()) ); 57 V8TRYCATCH_VOID(double, endTime, static_cast<double>(info[1]->NumberValue()) );
58 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, text, info[2]); 58 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, text, info[2]);
59 59
60 Document& document = *toDocument(getExecutionContext()); 60 Document& document = *toDocument(getExecutionContext());
61 UseCounter::count(document, UseCounter::TextTrackCueConstructor); 61 UseCounter::countDeprecation(document, UseCounter::TextTrackCueConstructor);
62 62
63 RefPtr<VTTCue> impl = VTTCue::create(document, startTime, endTime, text); 63 RefPtr<VTTCue> impl = VTTCue::create(document, startTime, endTime, text);
64 v8::Handle<v8::Object> wrapper = wrap(impl.get(), info.Holder(), info.GetIso late()); 64 v8::Handle<v8::Object> wrapper = wrap(impl.get(), info.Holder(), info.GetIso late());
65 65
66 v8SetReturnValue(info, wrapper); 66 v8SetReturnValue(info, wrapper);
67 } 67 }
68 68
69 } // namespace WebCore 69 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/media/track/text-track-cue-constructor-expected.txt ('k') | Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698